NAS-142088 / 27.0.0-BETA.1 / Update Containers UI for middleware container.* API changes (container.delete is now a job with force/recursive options) #3089
AlexKarpov98claude.yml
on: pull_request
review
/
...
/
Check member access
5s
review
/
Automatic PR review
9m 51s
Annotations
4 errors, 2 warnings, and 2 notices
|
review / Automatic PR review
Process completed with exit code 1.
|
|
review / Automatic PR review
2 finding(s) at or above MEDIUM
|
|
review / Automatic PR review:
src/app/pages/containers/components/all-containers/container-details/container-filesystem-devices/container-filesystem-devices.component.ts#L66
MEDIUM: isContainerActive() gates only edit/delete; the Add device action stays enabled on RUNNING/SUSPENDED containers and fails at submit. Same in the gpu, usb and nic cards.
|
|
review / Automatic PR review:
src/app/pages/containers/utils/container-status.utils.ts#L17
MEDIUM: Doc comment claims anything other than STOPPED is active, but isContainerActive excludes UNKNOWN, so rename and device edit gates stay open for UNKNOWN containers.
|
|
review / check-member / Check member access
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review:
src/app/pages/vm/vm-wizard/steps/4-network-interface-step/network-interface-step.component.ts#L57
LOW: Tightened MAC pattern on the VM fields has no withMessage, so previously-accepted dash-separated MACs now show only the generic Invalid format or character error.
|
|
review / Automatic PR review:
src/app/pages/containers/components/common/container-nic-form-dialog/container-nic-form-dialog.component.ts#L128
LOW: macTooltip concatenates two independently translated sentences with a space, which translators cannot reorder or rejoin.
|