fix(e2e): clear wrapped fields from any caret and type non-ASCII via clipboard

Step 33 has never passed in CI. Two independent harness bugs, both readable
straight off the failure log; the product path is correct.

Clearing assumed KEYCODE_MOVE_END reaches the end of the buffer, but it only
reaches the end of the current soft line. The topic draft is a multiline field
and the seeded topic wraps, so a centre tap plus MOVE_END plus backspaces
deleted the head and left the tail: the probe write landed as
"<probe> deterministic history", exactly the residue plus a fresh insert at
position 0.

`adb shell input text` synthesizes key events through the device
KeyCharacterMap, which has no sequence for U+2014, and one such character aborts
the whole command so nothing is typed. The restoration write left the header at
just " deterministic history" -- the partial-clear residue with zero characters
entered. Had only the dash been dropped, the ASCII remainder would have shown.

- add _e2e_clear_field, deleting both backward and forward from wherever the
  caret landed, and use it for the generic field helper and the topic draft
- route any text with non-printable-ASCII bytes through the device clipboard and
  KEYCODE_PASTE, which Compose maps to paste-at-caret
- add E2eClipboardReceiver, e2e build type only, to set the clipboard from the
  harness; exported so the adb shell uid can reach it
- fail the topic step when typing fails instead of saving a half-cleared draft

Fixing lib.sh rather than making the fixture topic ASCII: the restore contract
covers maintainer-configured channels whose topics can hold arbitrary unicode,
and any later journey typing user-visible strings meets the same limitation.

Author: trevarj

app/src/e2e/AndroidManifest.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools">
 
     <application>
         <!-- Test-only host for component instrumentation; see ComposeHostActivity. -->
@@ -8,6 +9,18 @@
             android:exported="false"
             android:theme="@style/Theme.Motd"
             android:windowSoftInputMode="adjustResize" />
+
+        <!-- E2E-only unicode text-entry bridge for test/e2e/lib.sh; see E2eClipboardReceiver.
+             Exported on purpose: the adb shell uid must reach it, this build type is never
+             shipped, and the worst a caller can do is set the emulator clipboard. -->
+        <receiver
+            android:name=".E2eClipboardReceiver"
+            android:exported="true"
+            tools:ignore="ExportedReceiver">
+            <intent-filter>
+                <action android:name="io.github.trevarj.motd.e2e.SET_CLIPBOARD" />
+            </intent-filter>
+        </receiver>
     </application>
 
 </manifest>

app/src/e2e/kotlin/io/github/trevarj/motd/E2eClipboardReceiver.kt

@@ -0,0 +1,35 @@
+package io.github.trevarj.motd
+
+import android.content.BroadcastReceiver
+import android.content.ClipData
+import android.content.ClipboardManager
+import android.content.Context
+import android.content.Intent
+import android.util.Base64
+
+/**
+ * E2E-only bridge for non-ASCII text entry from the shell harness.
+ *
+ * `adb shell input text` synthesizes key events through the device [android.view.KeyCharacterMap],
+ * which has no key sequence for characters outside the virtual keyboard's map (for example the
+ * U+2014 em dash in the seeded channel topic); a single such character makes the whole command
+ * abort and type nothing. test/e2e/lib.sh therefore broadcasts arbitrary text here base64-encoded,
+ * then presses KEYCODE_PASTE, which Compose maps to paste-at-caret in the focused text field.
+ *
+ * Ships only in the e2e build type (never debug/release) and is exported solely so the adb shell
+ * uid can reach it while the harness drives the foreground app.
+ */
+class E2eClipboardReceiver : BroadcastReceiver() {
+    override fun onReceive(context: Context, intent: Intent) {
+        val encoded = intent.getStringExtra(EXTRA_TEXT_B64) ?: return
+        // Base64 keeps the payload intact across the host shell, adb's re-quoting, and the device
+        // shell; decoding here is the only place the raw text is materialized.
+        val text = String(Base64.decode(encoded, Base64.DEFAULT), Charsets.UTF_8)
+        val clipboard = context.getSystemService(Context.CLIPBOARD_SERVICE) as ClipboardManager
+        clipboard.setPrimaryClip(ClipData.newPlainText("motd-e2e", text))
+    }
+
+    companion object {
+        const val EXTRA_TEXT_B64 = "text_b64"
+    }
+}

test/e2e/lib.sh

@@ -386,13 +386,42 @@ long_press_tag_prefix_containing_text() {
 
 # --- text input ------------------------------------------------------------
 
+# _e2e_clear_field <count> — empty the focused text field by deleting up to
+# <count> characters on BOTH sides of the cursor. Never trust cursor
+# positioning: a center tap drops the caret mid-text, and KEYCODE_MOVE_END only
+# reaches the end of the current SOFT line, so on a wrapped multiline field
+# "MOVE_END + backspaces" deletes the head and leaves the tail (nightly step 33
+# saved "<probe> deterministic history" exactly this way). Backward then forward
+# deletes clear the field from any caret position.
+_e2e_clear_field() {
+  local n="$1" i
+  local dels=() fwds=()
+  for ((i = 0; i < n; i++)); do dels+=(67); fwds+=(112); done   # 67=DEL, 112=FORWARD_DEL
+  adb_shell input keyevent "${dels[@]}"
+  adb_shell input keyevent "${fwds[@]}"
+}
+
 # _e2e_send_text <text> — type text via adb `input text`, safely. adb `input
 # text` treats space as an argument separator and interprets a few characters
 # specially; we escape spaces as %s and backslash-escape the shell-significant
 # ASCII punctuation so arbitrary values (passwords, URLs) type verbatim.
+# Text containing anything outside printable ASCII cannot go through `input
+# text` at all and is routed through the clipboard instead.
 _e2e_send_text() {
   local text="$1" out=""
   local i ch
+  # Empty text is a valid no-op (Phase D may restore an empty original topic; the field was
+  # already cleared). A bare `input text` with no argument would error instead.
+  [ -n "$text" ] || return 0
+  # `input text` synthesizes key events via the device KeyCharacterMap, which
+  # has no key sequence for characters like U+2014; one such character makes
+  # the whole command abort and type NOTHING (the nightly's topic restoration
+  # failed exactly this way). Detect any non-printable-ASCII byte and use the
+  # clipboard path, which handles arbitrary unicode.
+  if LC_ALL=C printf '%s' "$text" | grep -q '[^ -~]'; then
+    _e2e_send_text_via_clipboard "$text"
+    return
+  fi
   for (( i=0; i<${#text}; i++ )); do
     ch="${text:$i:1}"
     case "$ch" in
@@ -407,6 +436,25 @@ _e2e_send_text() {
   adb_shell input text "$out"
 }
 
+# _e2e_send_text_via_clipboard <text> — non-ASCII entry path. Hands the text
+# (base64, so it survives both shells verbatim) to the e2e build's
+# E2eClipboardReceiver, which puts it on the device clipboard, then presses
+# KEYCODE_PASTE; Compose's key mapping pastes it at the caret of the focused
+# field with no modifier key needed. Requires the :app e2e variant (the only
+# variant the emulator harness can install — debug/release are arm64-only).
+_e2e_send_text_via_clipboard() {
+  local b64
+  b64="$(printf '%s' "$1" | base64 | tr -d '\n')"
+  adb_shell am broadcast \
+    -n "${MOTD_PKG}/io.github.trevarj.motd.E2eClipboardReceiver" \
+    -a io.github.trevarj.motd.e2e.SET_CLIPBOARD \
+    --es text_b64 "$b64" >/dev/null 2>&1 || {
+    fail "clipboard broadcast failed; is the installed APK the e2e variant?"
+    return 1
+  }
+  adb_shell input keyevent 279   # KEYCODE_PASTE
+}
+
 # _e2e_input_by_fn <bounds-fn> <selector> <text> <label> — tap a field to focus
 # it, type the text, then close the keyboard (BACK). Caller should re-dump after
 # because the IME open/close shifts bounds (runbook flags every field step).
@@ -426,10 +474,8 @@ _e2e_input_by_fn() {
   # Give the IME a beat to attach focus before typing.
   sleep 1
   # Clear any pre-filled/default content (e.g. the Port field defaults to 6697) so typing
-  # REPLACES rather than appends. Move caret to end, then delete a generous run backward.
-  # 123=MOVE_END, 67=DEL; these fields are short (host/port/nick/user/pass).
-  adb_shell input keyevent 123
-  adb_shell input keyevent 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67 67
+  # REPLACES rather than appends. These fields are short (host/port/nick/user/pass).
+  _e2e_clear_field 40
   _e2e_send_text "$text"
   # Close the soft keyboard so subsequent dumps see the settled layout.
   adb_shell input keyevent 4   # KEYCODE_BACK

test/e2e/runbook.sh

@@ -109,7 +109,7 @@ MOTD_ROOT_READY_LABEL="Connected as ${MOTD_SOJU_USER}"
 # lib.sh. Keep this journey-specific helper on the stable field tag, and accept an empty original
 # topic so Phase D can restore either seeded or manually configured channels.
 input_topic_draft() {
-  local text="$1" bounds xy i
+  local text="$1" bounds xy
   dump || { fail "dump failed locating topic draft"; return 1; }
   bounds="$(bounds_of_tag channelinfo_topic_edit_text)"
   if [ -z "$bounds" ]; then
@@ -120,11 +120,10 @@ input_topic_draft() {
   # shellcheck disable=SC2086 # _e2e_center intentionally returns x y
   adb_shell input tap $xy
   sleep 1
-  adb_shell input keyevent 123
-  local deletes=()
-  for ((i = 0; i < 160; i++)); do deletes+=(67); done
-  adb_shell input keyevent "${deletes[@]}"
-  _e2e_send_text "$text"
+  # The draft wraps across soft lines, so clearing must not assume the caret can be moved to the
+  # true end of the buffer; _e2e_clear_field deletes both directions from wherever the tap put it.
+  _e2e_clear_field 160
+  _e2e_send_text "$text" || { fail "could not type topic draft"; return 1; }
   adb_shell input keyevent 4
   ok "input topic draft <= \"${text}\""
 }