WIP P2V migration + restore

Signed-off-by: Tiziano Bacocco <tizbac2@gmail.com>

Author: tizbac

directorybackup/main.go

@@ -284,7 +284,7 @@ func main() {
 
 func backup_stream(client *pbscommon.PBSClient, newchunk, reusechunk *atomic.Uint64, filename string, stream io.Reader) error {
 	knownChunks := hashmap.New[string, bool]()
-	client.Connect(false)
+	client.Connect(false, "host")
 	previousDidx, err := client.DownloadPreviousToBytes(filename)
 	if err != nil {
 		return err
@@ -345,7 +345,7 @@ func backup_stream(client *pbscommon.PBSClient, newchunk, reusechunk *atomic.Uin
 }
 
 func backup_real(client *pbscommon.PBSClient, newchunk, reusechunk *atomic.Uint64, pxarOut string, backupdir string) error {
-	client.Connect(false)
+	client.Connect(false, "host")
 	knownChunks := hashmap.New[string, bool]()
 
 	archive := &pbscommon.PXARArchive{}

machinebackup/config.go

@@ -35,13 +35,14 @@ type Config struct {
 	Datastore       string      `json:"datastore"`
 	Namespace       string      `json:"namespace"`
 	BackupID        string      `json:"backup-id"`
-	BackupDevice    string      `json:"backupdev"`
+	BackupDevices   []string    `json:"backupdev"`
 	SMTP            *SMTPConfig `json:"smtp"`
 	SysTray         bool        `json:"systray"`
+	BackupType      string      `json:"backuptype"`
 }
 
 func (c *Config) valid() bool {
-	baseValid := c.BaseURL != "" && c.AuthID != "" && c.Secret != "" && c.Datastore != "" && c.BackupDevice != ""
+	baseValid := c.BaseURL != "" && c.AuthID != "" && c.Secret != "" && c.Datastore != "" && len(c.BackupDevices) > 0
 	if !baseValid {
 		return baseValid
 	}
@@ -60,16 +61,31 @@ func (c *Config) valid() bool {
 	return true
 }
 
+type arrayFlags []string
+
+func (i *arrayFlags) String() string {
+	return fmt.Sprintf("%v", *i)
+}
+
+// Set is an implementation of the flag.Value interface
+func (i *arrayFlags) Set(value string) error {
+	*i = append(*i, value)
+	return nil
+}
 func loadConfig() *Config {
 	// Define flags
+
+	var backupdevs arrayFlags
+
 	baseURLFlag := flag.String("baseurl", "", "Base URL for the proxmox backup server, example: https://192.168.1.10:8007")
 	certFingerprintFlag := flag.String("certfingerprint", "", "Certificate fingerprint for SSL connection, example: ea:7d:06:f9...")
 	authIDFlag := flag.String("authid", "", "Authentication ID (PBS Api token)")
 	secretFlag := flag.String("secret", "", "Secret for authentication")
 	datastoreFlag := flag.String("datastore", "", "Datastore name")
 	namespaceFlag := flag.String("namespace", "", "Namespace (optional)")
 	backupIDFlag := flag.String("backup-id", "", "Backup ID (optional - if not specified, the hostname is used as the default)")
-	backupDEVFlag := flag.String("backupdev", "", "Backup device file ( On windows it can be \\\\.\\PhysicalDriveN , in that case VSS will be leveraged to take consistent snapshot), on linux can be /dev/sdX or whatever but not consistent for now unless it being an LVM snapshot or ZFS")
+	backupTypeFlag := flag.String("type", "", "host|vm , vm will allow to restore as VM inside proxmox VE (Physical to Virtual), also it enables to use file restore feature, use numeric backupid")
+	flag.Var(&backupdevs, "backupdev", "Can be specified multiple times,Backup device file ( On windows it can be \\\\.\\PhysicalDriveN , in that case VSS will be leveraged to take consistent snapshot), on linux can be /dev/sdX or whatever but not consistent for now unless it being an LVM snapshot or ZFS")
 	sysTrayFlag := flag.Bool("systray", false, "Enable systray( Note it can cause issues when running with no user logged in )")
 	mailHostFlag := flag.String("mail-host", "", "mail notification system: mail server host(optional)")
 	mailPortFlag := flag.String("mail-port", "", "mail notification system: mail server port(optional)")
@@ -86,7 +102,9 @@ func loadConfig() *Config {
 	// Parse command line flags
 	flag.Parse()
 
-	config := &Config{}
+	config := &Config{
+		BackupType: "host",
+	}
 	if *configFile != "" {
 		file, err := os.ReadFile(*configFile)
 		if err != nil {
@@ -121,13 +139,15 @@ func loadConfig() *Config {
 	if *backupIDFlag != "" {
 		config.BackupID = *backupIDFlag
 	}
-	if *backupDEVFlag != "" {
-		config.BackupDevice = *backupDEVFlag
-	}
+	config.BackupDevices = backupdevs
 	if *sysTrayFlag {
 		config.SysTray = true
 	}
 
+	if *backupTypeFlag != "" {
+		config.BackupType = *backupTypeFlag
+	}
+
 	initSmtpConfigIfNeeded := func() {
 		if config.SMTP == nil {
 			config.SMTP = &SMTPConfig{}

machinebackup/go.mod

@@ -4,6 +4,7 @@ go 1.24.4
 
 require (
 	github.com/go-ole/go-ole v1.2.6 // indirect
+	github.com/google/uuid v1.6.0 // indirect
 	github.com/lxn/win v0.0.0-20210218163916-a377121e959e // indirect
 	github.com/shirou/gopsutil v3.21.11+incompatible // indirect
 	github.com/yusufpapurcu/wmi v1.2.4 // indirect

machinebackup/go.sum

@@ -1,5 +1,7 @@
 github.com/go-ole/go-ole v1.2.6 h1:/Fpf6oFPoeFik9ty7siob0G6Ke8QvQEuVcuChpwXzpY=
 github.com/go-ole/go-ole v1.2.6/go.mod h1:pprOEPIfldk/42T2oK7lQ4v4JSDwmV0As9GaiUsvbm0=
+github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
+github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/lxn/win v0.0.0-20210218163916-a377121e959e h1:H+t6A/QJMbhCSEH5rAuRxh+CtW96g0Or0Fxa9IKr4uc=
 github.com/lxn/win v0.0.0-20210218163916-a377121e959e/go.mod h1:KxxjdtRkfNoYDCUP5ryK7XJJNTnpC8atvtmTheChOtk=
 github.com/shirou/gopsutil v3.21.11+incompatible h1:+1+c1VGhc88SSonWP6foOcLhvnKlUeu/erjjvaPEYiI=

machinebackup/main.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"bytes"
 	"crypto/sha256"
 	"encoding/hex"
 	"flag"
@@ -12,6 +13,7 @@ import (
 	"strconv"
 	"strings"
 	"sync"
+	"text/template"
 
 	"clientcommon"
 	"fmt"
@@ -21,6 +23,7 @@ import (
 	"sync/atomic"
 
 	"github.com/cornelk/hashmap"
+	"github.com/google/uuid"
 	"github.com/tawesoft/golib/v2/dialog"
 )
 
@@ -260,6 +263,11 @@ func backupFileDevice(client *pbscommon.PBSClient, filename string) error {
 	return uploadWorker(client, slug+".fidx", uint64(size), ch)
 }
 
+type BackupDisk struct {
+	Index int
+	Size  int64
+}
+
 func main() {
 
 	cfg := loadConfig()
@@ -307,22 +315,84 @@ func main() {
 		},
 	}
 
-	//Physycal drive paths will be like  "\\\\.\\PhysicalDrive0"
-	client.Connect(false)
-	if strings.HasPrefix(cfg.BackupDevice, "\\\\.\\PhysicalDrive") {
+	//Physical drive paths will be like  "\\\\.\\PhysicalDrive0"
+	client.Connect(false, cfg.BackupType)
+	disks := make([]BackupDisk, 0)
+
+	for _, dev := range cfg.BackupDevices {
+		if strings.HasPrefix(dev, "\\\\.\\PhysicalDrive") {
 
-		re := regexp.MustCompile(`PhysicalDrive(\d+)$`)
-		matches := re.FindStringSubmatch(cfg.BackupDevice)
-		idx, _ := strconv.ParseInt(matches[1], 10, 32)
-		err := backupWindowsDisk(client, int(idx))
+			re := regexp.MustCompile(`PhysicalDrive(\d+)$`)
+			matches := re.FindStringSubmatch(dev)
+			idx, _ := strconv.ParseInt(matches[1], 10, 32)
+			size, err := backupWindowsDisk(client, int(idx))
+			if err != nil {
+				panic(err)
+			}
+			disks = append(disks, BackupDisk{
+				Index: int(idx),
+				Size:  size,
+			})
+		} else {
+			err := backupFileDevice(client, dev)
+			if err != nil {
+				panic(err)
+			}
+		}
+	}
+
+	if cfg.BackupType == "vm" {
+		type ConfigTemplate struct {
+			VMGenId string
+			VMID    int64
+			VMName  string
+			Disks   []BackupDisk
+			OS      string
+			SMBIOS  string
+		}
+
+		tmpl, err := template.New("qemuconfig").Parse(`boot: order=sata0
+cores: 4
+machine: q35
+memory: 2048
+name: {{.VMName}}
+numa: 0
+onboot: 0
+ostype: {{.OS}}
+scsihw: virtio-scsi-single
+smbios1: uuid={{.SMBIOS}}
+sockets: 1
+{{range .Disks}}
+sata{{.Index}}: local:{{.VMID}}/vm-{{.VMID}}-disk-{{.Index}}.raw,cache=writeback,discard=on,iothread=1,size={{.Size}}
+{{end}}
+vmgenid: {{.VMGenId}}
+		`)
 		if err != nil {
 			panic(err)
 		}
-	} else {
-		err := backupFileDevice(client, cfg.BackupDevice)
+		vmid, err := strconv.ParseInt(cfg.BackupID, 10, 32)
+		if err != nil {
+			panic(err)
+		}
+		hostname, err := os.Hostname()
 		if err != nil {
 			panic(err)
 		}
+		wr := bytes.Buffer{}
+		cfgt := ConfigTemplate{
+			VMGenId: uuid.New().String(),
+			VMID:    vmid,
+			Disks:   disks,
+			VMName:  hostname,
+			SMBIOS:  uuid.New().String(), //TODO extract from real machine
+		}
+		if runtime.GOOS == "windows" { // TODO Improve
+			cfgt.OS = "win11"
+		} else {
+			cfgt.OS = "l26"
+		}
+		tmpl.Execute(&wr, cfgt)
+		client.UploadBlob("qemu-server.conf.blob", wr.Bytes())
 	}
 
 	err := client.UploadManifest()

machinebackup/nonwin.go

@@ -8,8 +8,8 @@ import (
 	"pbscommon"
 )
 
-func backupWindowsDisk(client *pbscommon.PBSClient, index int) error {
-	return fmt.Errorf("Not supported on this platform")
+func backupWindowsDisk(client *pbscommon.PBSClient, index int) (int64, error) {
+	return 0, fmt.Errorf("Not supported on this platform")
 }
 
 func sysTraySetup() {

machinebackup/windows.go

@@ -247,7 +247,7 @@ func GetDiskLength(path string) (int64, error) {
 	return lengthInfo.Length, nil
 }
 
-func backupWindowsDisk(client *pbscommon.PBSClient, index int) error {
+func backupWindowsDisk(client *pbscommon.PBSClient, index int) (int64, error) {
 	parts := make([]Partition, 0)
 	ch := make(chan []byte)
 	diskdev := fmt.Sprintf("\\\\.\\PhysicalDrive%d", index)
@@ -352,10 +352,10 @@ func backupWindowsDisk(client *pbscommon.PBSClient, index int) error {
 
 	total, err := GetDiskLength(diskdev)
 	if err != nil {
-		return err
+		return 0, err
 	}
 
-	return snapshot.CreateVSSSnapshot(snapshot_paths, func(snapshots map[string]snapshot.SnapShot) error {
+	return total, snapshot.CreateVSSSnapshot(snapshot_paths, func(snapshots map[string]snapshot.SnapShot) error {
 
 		/*hostname, err := os.Hostname()
 		if err != nil {
@@ -509,7 +509,7 @@ func backupWindowsDisk(client *pbscommon.PBSClient, index int) error {
 			close(ch)
 		}()
 
-		return uploadWorker(client, fmt.Sprintf("windisk%d.fidx", index), uint64(total), ch)
+		return uploadWorker(client, fmt.Sprintf("drive-sata%d.img.fidx", index), uint64(total), ch)
 
 	})
 }