Skip to content

Commit 0e56614

Browse files
committed
fix: prevent badge parse empty string as zero
1 parent da0cd2d commit 0e56614

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

src/Badge.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,12 @@ export const Badge: React.FC<BadgeProps> = (props) => {
1616
const { className, style, children, dot, value, maxValue = 99 } = props
1717

1818
const text = useMemo(() => {
19-
const num = Number(value)
20-
21-
if (Number.isInteger(num)) {
22-
return num > maxValue ? `${maxValue}+` : num.toString()
23-
} else if (typeof value === 'string') {
19+
if (value === '' || value === null || typeof value === 'undefined') return ''
20+
const numValue = +value
21+
if (Number.isNaN(numValue)) {
2422
return value
25-
} else {
26-
return ''
2723
}
24+
return numValue > maxValue ? `${maxValue}+` : numValue
2825
}, [value, maxValue])
2926

3027
return (

0 commit comments

Comments
 (0)