changing lint stack

formatter and linting to ruff, and types to pyrefly

Author: aleivag

.github/workflows/ci.yml

@@ -8,31 +8,40 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ['3.10', '3.11', '3.12', '3.13']
+        python: ['3.11', '3.12', '3.13', '3.14']
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-    - name: Setup Python
-      uses: actions/setup-python@v2
+    - name: Install uv
+      uses: astral-sh/setup-uv@v7
       with:
         python-version: ${{ matrix.python }}
     - name: update APT
       run: sudo apt-get update
     - name: Install dependencies
       run: sudo apt-get install -y libsystemd-dev
-    - name: Install pystemd
-      run: pip install -e '.[t]'
+    - name: Install environment
+      run: uv sync --all-extras --dev
+
+    - name: Assert Python Version
+      run: uv run python -V
+
     - name: Run unit tests
-      run: pytest --cov=pystemd tests
+      run: uv run pytest --cov=pystemd tests
 
   formatting:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-    - name: Run black
-      uses: psf/black@stable
+    - name: Run ruff
+      uses: astral-sh/ruff-action@v3
+      with:
+        src: >-
+          pystemd
+          examples
+          tests
     - name: Run isort
       uses: isort/isort-action@v1
 
@@ -42,7 +51,16 @@ jobs:
     steps:
     - name: Checkout repository
       uses: actions/checkout@v2
-    - name: install mypy
-      run:  pip install mypy types-psutil
-    - name: run mypy
-      run: mypy
+    - name: Install uv
+      uses: astral-sh/setup-uv@v7
+
+    - name: update APT
+      run: sudo apt-get update
+    - name: Install dependencies
+      run: sudo apt-get install -y libsystemd-dev
+    
+    - name: install environment
+      run:  uv sync --extra lint
+    - name: run pyrefly
+      run: uv run pyrefly check pystemd examples tests
+

examples/future_cpucap_process.py

@@ -13,6 +13,7 @@ def __init__(self, timeout, properties):
         self.timeout = timeout
         super().__init__(properties=properties)
 
+    # pyrefly: ignore [bad-override]
     def run(self):
         """
         This is suppose to waste a bunch of CPU.

examples/manager.py

@@ -16,7 +16,9 @@
 
 def list_units():
     with Manager() as manager:
+        # pyrefly: ignore [missing-attribute]
         print("Version", manager.Manager.Version)
+        # pyrefly: ignore [missing-attribute]
         print("Architecture", manager.Manager.Architecture)
 
         # List Units

examples/monitor.py

@@ -48,6 +48,7 @@ def monitor(*args):
             cargs,
         )
 
+        # pyrefly: ignore [missing-attribute]
         name = bus.get_unique_name()
         while True:
             msg = bus.process()

examples/monitor_from_signal.py

@@ -36,6 +36,7 @@ def process(msg, error=None, userdata=None):
 
     if msg.body[1].get(b"SubState") in (b"exited", b"failed", b"dead"):
         print("Unit is dead, exiting select loop")
+        # pyrefly: ignore [missing-attribute]
         userdata.EXIT = True
     print("#" * 80)
     print("\n")

examples/shell.py

@@ -18,6 +18,7 @@
 import sys
 from pathlib import Path
 
+# pyrefly: ignore [missing-import]
 from IPython.terminal.embed import InteractiveShellEmbed
 
 import pystemd
@@ -27,9 +28,7 @@
 
 display_banner = """
 Welcome to pystemd  {pystemd.__version__} interactive shell for python {sys.version}.
-""".format(
-    pystemd=pystemd, sys=sys
-)
+""".format(pystemd=pystemd, sys=sys)
 
 
 def shell() -> None:
@@ -39,6 +38,7 @@ def shell() -> None:
 
 
 def main(mod: Path) -> None:
+    # pyrefly: ignore [bad-argument-type]
     runpy.run_path(mod, {}, "__main__")
 
 

examples/start_transient_unit.py

@@ -28,7 +28,9 @@ def start_transient_unit(cmd="/bin/sleep 15"):
     }
     # if we need interactive prompts for passwords, we can create our own DBus object.
     # if we dont need interactive, we would just do `with Manager() as manager:`.
+    # pyrefly: ignore [unexpected-keyword]
     with DBus(interactive=True) as bus, Manager(bus=bus) as manager:
+        # pyrefly: ignore [missing-argument]
         manager.Manager.StartTransientUnit(random_unit_name, b"fail", unit)
 
         with Unit(random_unit_name, bus=bus) as unit:

pyproject.toml

@@ -7,6 +7,7 @@ name = "pystemd"
 version = "0.14.0"
 readme = "README.md"
 description="A systemd binding for python"
+requires-python=">=3.11"
 dependencies = [
     "lxml",
     "psutil"
@@ -21,12 +22,11 @@ classifiers = [
     "Operating System :: POSIX :: Linux",
     "Intended Audience :: Developers",
     "Intended Audience :: System Administrators",
-    "Programming Language :: Python :: 3.6",
-    "Programming Language :: Python :: 3.7",
-    "Programming Language :: Python :: 3.8",
-    "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
+    "Programming Language :: Python :: 3.14",
     "Development Status :: 5 - Production/Stable",
     "Topic :: Utilities",
     "License :: OSI Approved :: GNU Lesser General Public License v2 or later (LGPLv2+)",
@@ -40,11 +40,12 @@ t = [
   "pytest", 
   "pytest-cov", 
   # cstq and toml are used for testing version
-  "cstq", "toml"
+  "cstq", 
+  "toml",
 ]
 lint = [
-    "black",
-    "mypi",
+    "ruff",
+    "pyrefly",
     "isort",
 ]
 

pystemd/__init__.pyi

@@ -8,7 +8,7 @@
 
 from typing import Any
 
-from pystemd import DBus, __version__, machine1, systemd1
+from pystemd import machine1, systemd1
 
 SDUnit = systemd1.Unit
 SDManager = systemd1.Manager

pystemd/__version__.py

@@ -10,6 +10,6 @@
 
 # during development this version is always at least "one up" the
 # latest release.
-__version__ = "0.14.0"
+__version__ = "0.15.0"
 
 sys.modules[__name__] = __version__  # type: ignore