feat!: Remove XBM support

Author: sorairolake

BUILD.adoc

@@ -93,10 +93,6 @@ The man pages are generated in `docs/man/man1`.
 
   Enable decoding from the WebP image. This is enabled by default.
 
-`decode-from-xbm`::
-
-  Enable decoding from the XBM image. This is enabled by default.
-
 `optimize-output-png`::
 
   Enable options to optimize output PNG image. This is enabled by default.

CHANGELOG.adoc

@@ -20,6 +20,10 @@ project adheres to https://semver.org/[Semantic Versioning].
 
 * Bump MSRV to 1.89.0 ({pull-request-url}/954[#954])
 
+=== Removed
+
+* Remove XBM support ({pull-request-url}/984[#984])
+
 == {compare-url}/v0.13.1\...v0.13.2[0.13.2] - 2025-12-20
 
 === Added

Cargo.lock

@@ -28,7 +28,6 @@ image = { version = "0.25.10", default-features = false, features = [
   "png",
   "rayon",
 ] }
-image-extras = { version = "0.1.0", default-features = false, optional = true }
 is-svg = { version = "0.2.2", optional = true }
 oxipng = { version = "10.1.0", default-features = false, features = [
   "parallel",
@@ -60,7 +59,6 @@ default = [
   "decode-from-tga",
   "decode-from-tiff",
   "decode-from-webp",
-  "decode-from-xbm",
   "optimize-output-png",
   "output-as-ansi",
 ]
@@ -78,7 +76,6 @@ decode-from-svg = ["dep:is-svg", "dep:resvg"]
 decode-from-tga = ["image/tga"]
 decode-from-tiff = ["image/tiff"]
 decode-from-webp = ["image/webp"]
-decode-from-xbm = ["dep:image-extras", "image-extras/xbm"]
 optimize-output-png = ["dep:oxipng"]
 output-as-ansi = [
   "dep:anstyle",

Cargo.toml

@@ -170,7 +170,6 @@ List of supported image formats:
 - [TGA]
 - [TIFF]
 - [WebP]
-- [XBM]
 
 To support decoding from SVG image, the `decode-from-svg` feature must be
 enabled at compile time. Note that the SVG image is rasterized before scanning.
@@ -365,7 +364,6 @@ licensing information.
 [TGA]: https://en.wikipedia.org/wiki/Truevision_TGA
 [TIFF]: https://en.wikipedia.org/wiki/TIFF
 [WebP]: https://developers.google.com/speed/webp/
-[XBM]: https://en.wikipedia.org/wiki/X_BitMap
 [`oxipng`]: https://github.com/shssoichiro/oxipng
 [`svgcleaner`]: https://github.com/RazrFalcon/svgcleaner
 [ImageMagick]: https://imagemagick.org/

README.md

@@ -25,7 +25,6 @@
 :tga-url: {enwp-article-url}/Truevision_TGA
 :tiff-url: {enwp-article-url}/TIFF
 :webp-url: https://developers.google.com/speed/webp/
-:xbm-url: {enwp-article-url}/X_BitMap
 :oxipng-repo-url: {github-url}/shssoichiro/oxipng
 :svgcleaner-repo-url: {github-url}/RazrFalcon/svgcleaner
 :imagemagick-url: https://imagemagick.org/
@@ -145,7 +144,6 @@ the output format, etc.
 * {tga-url}[TGA]
 * {tiff-url}[TIFF]
 * {webp-url}[WebP]
-* {xbm-url}[XBM]
 
 To support decoding from SVG image, the `decode-from-svg` feature must be
 enabled at compile time. Note that the SVG image is rasterized before scanning.

docs/book/modules/ROOT/pages/usage.adoc

@@ -4,7 +4,7 @@
 
 = qrtool-decode(1)
 // Specify in UTC.
-:docdate: 2025-11-28
+:docdate: 2026-04-12
 :revnumber: 0.13.2
 :doctype: manpage
 :mansource: qrtool {revnumber}
@@ -29,7 +29,6 @@ ifndef::site-gen-antora[:includedir: ./include]
 :tga-url: {enwp-article-url}/Truevision_TGA
 :tiff-url: {enwp-article-url}/TIFF
 :webp-url: https://developers.google.com/speed/webp/
-:xbm-url: {enwp-article-url}/X_BitMap
 :qrcode-codes: {qrcode-url}/codes
 :normal-qr-code-url: {qrcode-codes}/model12.html
 :micro-qr-code-url: {qrcode-codes}/microqr.html
@@ -65,7 +64,6 @@ vector image. By default, the result will be output to standard output.
 * {tga-url}[TGA] (if enabled at compile time)
 * {tiff-url}[TIFF] (if enabled at compile time)
 * {webp-url}[WebP] (if enabled at compile time)
-* {xbm-url}[XBM] (if enabled at compile time)
 
 Use *-t* option to specify the image format. If this option is not specified,
 the image format is determined based on the extension or the magic number.
@@ -169,11 +167,6 @@ _IMAGE_::
       WebP. This value is available if the `decode-from-webp` feature is
       enabled at compile time.
 
-    *xbm*::::
-
-      X BitMap. This value is available if the `decode-from-xbm` feature is
-      enabled at compile time.
-
 *--verbose*::
 
   Also print the metadata. It is output to stderr. This option conflicts with

docs/man/man1/qrtool-decode.1.adoc

@@ -12,17 +12,13 @@ use std::{
 
 use anyhow::Context;
 use clap::Parser;
-#[cfg(feature = "decode-from-xbm")]
-use image::DynamicImage;
 use image::{ImageFormat, imageops};
-#[cfg(feature = "decode-from-xbm")]
-use image_extras::xbm::XbmDecoder;
 #[cfg(feature = "optimize-output-png")]
 use oxipng::{Deflater, Options, ZopfliOptions};
 use qrcode2::{QrCode, bits::Bits};
 use rqrr::PreparedImage;
 
-#[cfg(any(feature = "decode-from-svg", feature = "decode-from-xbm"))]
+#[cfg(feature = "decode-from-svg")]
 use crate::cli::InputFormat;
 use crate::{
     cli::{Command, Opt, OutputFormat, Variant},
@@ -191,19 +187,10 @@ pub fn run() -> anyhow::Result<()> {
             #[cfg(feature = "decode-from-svg")]
             let input_format =
                 input_format.or_else(|| is_svg::is_svg(&input).then_some(InputFormat::Svg));
-            #[cfg(feature = "decode-from-xbm")]
-            let input_format =
-                input_format.or_else(|| input.starts_with(b"#define").then_some(InputFormat::Xbm));
             #[expect(clippy::option_if_let_else)]
             let image = match input_format {
                 #[cfg(feature = "decode-from-svg")]
                 Some(InputFormat::Svg) => decode::from_svg(&input),
-                #[cfg(feature = "decode-from-xbm")]
-                Some(InputFormat::Xbm) => {
-                    let decoder = XbmDecoder::new(Cursor::new(input))
-                        .context("could not create new XBM decoder")?;
-                    DynamicImage::from_decoder(decoder).map_err(anyhow::Error::from)
-                }
                 format => {
                     let format = if let Some(f) = format {
                         f.try_into()

src/app.rs

@@ -15,7 +15,7 @@ use anyhow::anyhow;
 use clap::{Args, CommandFactory, Parser, Subcommand, ValueEnum, ValueHint};
 use clap_complete::Generator;
 use csscolorparser::Color;
-#[cfg(any(feature = "decode-from-svg", feature = "decode-from-xbm"))]
+#[cfg(feature = "decode-from-svg")]
 use image::error::ImageFormatHint;
 use image::{ImageError, ImageFormat};
 use qrcode2::EcLevel;
@@ -580,10 +580,6 @@ pub enum InputFormat {
     /// WebP.
     #[cfg(feature = "decode-from-webp")]
     WebP,
-
-    /// X BitMap.
-    #[cfg(feature = "decode-from-xbm")]
-    Xbm,
 }
 
 impl TryFrom<InputFormat> for ImageFormat {
@@ -620,8 +616,6 @@ impl TryFrom<InputFormat> for ImageFormat {
             InputFormat::Tiff => Ok(Self::Tiff),
             #[cfg(feature = "decode-from-webp")]
             InputFormat::WebP => Ok(Self::WebP),
-            #[cfg(feature = "decode-from-xbm")]
-            InputFormat::Xbm => Err(Self::Error::Unsupported(ImageFormatHint::Unknown.into())),
         }
     }
 }
@@ -769,7 +763,5 @@ mod tests {
             ImageFormat::try_from(InputFormat::WebP).unwrap(),
             ImageFormat::WebP
         );
-        #[cfg(feature = "decode-from-xbm")]
-        assert!(ImageFormat::try_from(InputFormat::Xbm).is_err());
     }
 }