Fix stray whitespace in tag cloud links (#1437)

Author: sissbruecker

bookmarks/templates/bookmarks/tag_cloud.html

@@ -4,9 +4,7 @@
   {% if tag_cloud.has_selected_tags %}
     <p class="selected-tags">
       {% for tag in tag_cloud.selected_tags %}
-        <a href="?{{ tag.query_string }}" class="text-bold mr-2">
-          <span>-{{ tag.name }}</span>
-        </a>
+        <a href="?{{ tag.query_string }}" class="text-bold mr-2"><span>-{{ tag.name }}</span></a>
       {% endfor %}
     </p>
   {% endif %}
@@ -16,14 +14,10 @@
         {% for tag in group.tags %}
           {# Highlight first char of first tag in group if grouping is enabled #}
           {% if group.highlight_first_char and forloop.counter == 1 %}
-            <a href="?{{ tag.query_string }}" class="mr-2" data-is-tag-item>
-              <span class="highlight-char">{{ tag.name|first_char }}</span><span>{{ tag.name|remaining_chars:1 }}</span>
-            </a>
+            <a href="?{{ tag.query_string }}" class="mr-2" data-is-tag-item><span class="highlight-char">{{ tag.name|first_char }}</span><span>{{ tag.name|remaining_chars:1 }}</span></a>
           {% else %}
             {# Render tags normally #}
-            <a href="?{{ tag.query_string }}" class="mr-2" data-is-tag-item>
-              <span>{{ tag.name }}</span>
-            </a>
+            <a href="?{{ tag.query_string }}" class="mr-2" data-is-tag-item><span>{{ tag.name }}</span></a>
           {% endif %}
         {% endfor %}
       </p>

bookmarks/tests/test_tag_cloud_template.py

@@ -546,3 +546,28 @@ def test_with_anonymous_user(self):
         """,
             rendered_template,
         )
+
+    def test_tag_links_have_no_whitespace_around_contents(self):
+        tags = [
+            self.setup_tag(name="tag1"),
+            self.setup_tag(name="tag2"),
+            self.setup_tag(name="tag3"),
+        ]
+        self.setup_bookmark(tags=tags)
+
+        rendered_template = self.render_template(url="/test?q=%23tag1")
+
+        soup = self.make_soup(rendered_template)
+        link_elements = soup.select(".tag-cloud a")
+        self.assertEqual(len(link_elements), 3)
+
+        for link_element in link_elements:
+            contents = link_element.decode_contents()
+            self.assertTrue(
+                contents.startswith("<span"),
+                f"unexpected characters after opening anchor tag: {contents!r}",
+            )
+            self.assertTrue(
+                contents.endswith("</span>"),
+                f"unexpected characters before closing anchor tag: {contents!r}",
+            )