|
| 1 | +// This Source Code Form is subject to the terms of the Mozilla Public |
| 2 | +// License, v. 2.0. If a copy of the MPL was not distributed with this |
| 3 | +// file, You can obtain one at http://mozilla.org/MPL/2.0/. |
| 4 | + |
| 5 | +// nolint: contextcheck,godoclint |
| 6 | +package ssa_test |
| 7 | + |
| 8 | +import ( |
| 9 | + "context" |
| 10 | + "errors" |
| 11 | + "sync/atomic" |
| 12 | + "testing" |
| 13 | + "time" |
| 14 | + |
| 15 | + "github.com/fluxcd/cli-utils/pkg/object" |
| 16 | + fluxssa "github.com/fluxcd/pkg/ssa" |
| 17 | + "github.com/stretchr/testify/assert" |
| 18 | + "github.com/stretchr/testify/require" |
| 19 | + apierrors "k8s.io/apimachinery/pkg/api/errors" |
| 20 | + |
| 21 | + "github.com/siderolabs/go-kubernetes/kubernetes/ssa" |
| 22 | + "github.com/siderolabs/go-kubernetes/kubernetes/ssa/internal/resourcemanager" |
| 23 | +) |
| 24 | + |
| 25 | +// retryableWaitResourceManager returns a retryable error for the first N calls |
| 26 | +// to WaitForSetWithContext, then succeeds. |
| 27 | +type retryableWaitResourceManager struct { |
| 28 | + resourcemanager.Mock |
| 29 | + remaining atomic.Int32 |
| 30 | +} |
| 31 | + |
| 32 | +func (m *retryableWaitResourceManager) WaitForSetWithContext(_ context.Context, _ object.ObjMetadataSet, _ fluxssa.WaitOptions) error { |
| 33 | + if m.remaining.Add(-1) >= 0 { |
| 34 | + return apierrors.NewInternalError(errors.New("transient API server error")) |
| 35 | + } |
| 36 | + |
| 37 | + return nil |
| 38 | +} |
| 39 | + |
| 40 | +func TestWait(t *testing.T) { |
| 41 | + t.Run("retries_on_transient_error_then_succeeds", func(t *testing.T) { |
| 42 | + rm := &retryableWaitResourceManager{} |
| 43 | + rm.remaining.Store(2) // fail twice, succeed on third |
| 44 | + |
| 45 | + manager := ssa.NewCustomManager(rm, testInventoryFactory, nil, &mapperMock{}) |
| 46 | + |
| 47 | + err := manager.Wait(t.Context(), object.ObjMetadataSet{}, ssa.WaitOptions{ |
| 48 | + Timeout: 30 * time.Second, |
| 49 | + Interval: 1 * time.Second, |
| 50 | + }) |
| 51 | + require.NoError(t, err) |
| 52 | + |
| 53 | + // remaining should be -1 |
| 54 | + assert.Equal(t, rm.remaining.Load(), int32(-1)) |
| 55 | + }) |
| 56 | + |
| 57 | + t.Run("respects_timeout_budget", func(t *testing.T) { |
| 58 | + // Always returns a retryable error — Wait must still return within the timeout. |
| 59 | + rm := &retryableWaitResourceManager{} |
| 60 | + rm.remaining.Store(1000) // never succeeds |
| 61 | + |
| 62 | + manager := ssa.NewCustomManager(rm, testInventoryFactory, nil, &mapperMock{}) |
| 63 | + |
| 64 | + timeout := 3 * time.Second |
| 65 | + |
| 66 | + start := time.Now() |
| 67 | + |
| 68 | + err := manager.Wait(t.Context(), object.ObjMetadataSet{}, ssa.WaitOptions{ |
| 69 | + Timeout: timeout, |
| 70 | + Interval: 500 * time.Millisecond, |
| 71 | + }) |
| 72 | + elapsed := time.Since(start) |
| 73 | + |
| 74 | + require.Error(t, err) |
| 75 | + assert.Less(t, elapsed, timeout+100*time.Millisecond, "Wait should not exceed timeout by more than a small margin") |
| 76 | + }) |
| 77 | + |
| 78 | + t.Run("non_retryable_error_returns_immediately", func(t *testing.T) { |
| 79 | + rm := &permanentWaitFailResourceManager{err: errors.New("resources failed")} |
| 80 | + |
| 81 | + manager := ssa.NewCustomManager(rm, testInventoryFactory, nil, &mapperMock{}) |
| 82 | + |
| 83 | + start := time.Now() |
| 84 | + |
| 85 | + err := manager.Wait(t.Context(), object.ObjMetadataSet{}, ssa.WaitOptions{ |
| 86 | + Timeout: 30 * time.Second, |
| 87 | + Interval: 1 * time.Second, |
| 88 | + }) |
| 89 | + elapsed := time.Since(start) |
| 90 | + |
| 91 | + require.ErrorContains(t, err, "resources failed") |
| 92 | + assert.Less(t, elapsed, 2*time.Second, "non-retryable error should return immediately") |
| 93 | + }) |
| 94 | +} |
| 95 | + |
| 96 | +// permanentWaitFailResourceManager always returns a non-retryable error. |
| 97 | +type permanentWaitFailResourceManager struct { |
| 98 | + resourcemanager.Mock |
| 99 | + err error |
| 100 | +} |
| 101 | + |
| 102 | +func (m *permanentWaitFailResourceManager) WaitForSetWithContext(_ context.Context, _ object.ObjMetadataSet, _ fluxssa.WaitOptions) error { |
| 103 | + return m.err |
| 104 | +} |
0 commit comments