Merge commit 'ddf906756a638175410aa06997f138a1acb75404' into pr-7679-xplat-ci

Author: danielhanchen

studio/frontend/src/features/hub/lib/format.ts

@@ -1,6 +1,12 @@
 // SPDX-License-Identifier: AGPL-3.0-only
 // Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
 
+const SECONDS_PER_MINUTE = 60;
+const MINUTES_PER_HOUR = 60;
+const HOURS_PER_DAY = 24;
+const SECONDS_PER_HOUR = SECONDS_PER_MINUTE * MINUTES_PER_HOUR;
+const MAX_DISPLAYABLE_ETA_SECONDS = HOURS_PER_DAY * SECONDS_PER_HOUR;
+
 export function formatBytes(bytes: number): string {
   if (!Number.isFinite(bytes) || bytes < 0) return "N/A";
   if (bytes === 0) return "0 B";
@@ -27,20 +33,16 @@ export function formatRate(bytesPerSec: number): string {
 export function formatEta(seconds: number): string {
   if (!Number.isFinite(seconds) || seconds <= 0) return "";
   const s = Math.round(seconds);
-  if (s < 60) return `${s}s left`;
-  if (s < 3600) {
-    const m = Math.floor(s / 60);
-    const rem = s % 60;
+  if (s >= MAX_DISPLAYABLE_ETA_SECONDS) return "";
+  if (s < SECONDS_PER_MINUTE) return `${s}s left`;
+  if (s < SECONDS_PER_HOUR) {
+    const m = Math.floor(s / SECONDS_PER_MINUTE);
+    const rem = s % SECONDS_PER_MINUTE;
     return rem ? `${m}m ${rem}s left` : `${m}m left`;
   }
-  if (s < 86400) {
-    const h = Math.floor(s / 3600);
-    const rem = Math.floor((s % 3600) / 60);
-    return rem ? `${h}h ${rem}m left` : `${h}h left`;
-  }
-  const d = Math.floor(s / 86400);
-  const rem = Math.floor((s % 86400) / 3600);
-  return rem ? `${d}d ${rem}h left` : `${d}d left`;
+  const h = Math.floor(s / SECONDS_PER_HOUR);
+  const rem = Math.floor((s % SECONDS_PER_HOUR) / SECONDS_PER_MINUTE);
+  return rem ? `${h}h ${rem}m left` : `${h}h left`;
 }
 
 export function ownerOf(id: string): string {

studio/frontend/tests/hub-format.test.ts

@@ -0,0 +1,30 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+// Copyright 2026-present the Unsloth AI Inc. team. All rights reserved. See /studio/LICENSE.AGPL-3.0
+
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import { formatEta } from "../src/features/hub/lib/format.ts";
+
+const SECONDS_PER_MINUTE = 60;
+const MINUTES_PER_HOUR = 60;
+const HOURS_PER_DAY = 24;
+const REPRO_ETA_DAYS = 753;
+const REPRO_ETA_HOURS = 5;
+const SECONDS_PER_HOUR = SECONDS_PER_MINUTE * MINUTES_PER_HOUR;
+const MAX_DISPLAYABLE_ETA_SECONDS = HOURS_PER_DAY * SECONDS_PER_HOUR;
+const REPRO_ETA_SECONDS =
+  (REPRO_ETA_DAYS * HOURS_PER_DAY + REPRO_ETA_HOURS) * SECONDS_PER_HOUR;
+
+test("download ETA hides estimates that are too uncertain to be useful", () => {
+  assert.equal(formatEta(Number.NaN), "");
+  assert.equal(formatEta(0), "");
+  assert.equal(formatEta(SECONDS_PER_MINUTE - 1), "59s left");
+  assert.equal(formatEta(SECONDS_PER_MINUTE), "1m left");
+  assert.equal(formatEta(SECONDS_PER_MINUTE + 1), "1m 1s left");
+  assert.equal(formatEta(SECONDS_PER_HOUR), "1h left");
+  assert.equal(formatEta(SECONDS_PER_HOUR + SECONDS_PER_MINUTE), "1h 1m left");
+  assert.equal(formatEta(REPRO_ETA_SECONDS), "");
+  assert.equal(formatEta(MAX_DISPLAYABLE_ETA_SECONDS - 1), "23h 59m left");
+  assert.equal(formatEta(MAX_DISPLAYABLE_ETA_SECONDS), "");
+});