Commit f603c56
Pin @babel/preset-react to v7 in generator e2e template
The generator specs' react e2e template installed @babel/preset-react
with no version constraint. @babel/preset-react@8 was published requiring
@babel/core ^8 as a peer, but Shakapacker's generated app uses
@babel/core ^7. npm therefore resolved the unpinned add to v8 and failed
with ERESOLVE, which aborted the whole `npm add` and left react and
react-dom uninstalled. The subsequent bin/shakapacker build then failed
with "Module not found: Can't resolve 'react'", breaking the Generator
specs job on main and every PR.
Pin to @babel/preset-react@^7 to match the app's @babel/core ^7, matching
the existing pin already used in spec/dummy.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 81b5634 commit f603c56
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
9 | 14 | | |
10 | 15 | | |
11 | 16 | | |
| |||
0 commit comments