Commit e88c19b
Tighten binstub sync coverage and helper specs (#1123)
Address the medium-priority test-coverage follow-ups from the PR #1104
review.
1. Cover spec/dummy/bin/shakapacker-config in the sync spec. The dummy
binstub used by the test app must stay byte-identical to the install
template; otherwise a stale wrapper could silently mask install-
template changes.
2. Add a JS test that invokes createBinStub for both helper binstub
names and asserts the generated content is byte-identical to the
checked-in lib/install/bin/* files. Exports createBinStub from
package/configExporter/cli.ts so the test can reach it. This closes
the gap where the Ruby sync spec couldn't reach into the JS template.
3. Assert the `[Shakapacker] No Gemfile found at …` warning in
helper_binstubs_spec.rb so the fallback path can't lose its warning
silently.
4. Update the "Keep in sync" comment in all four locations to list all
four copies (the previous wording said "all three" and missed the
dummy binstub).
5. Rename the "documents every divergent binstub and only divergent
binstubs" example to "all documented divergent binstubs still exist
in both directories" so the name matches what the test actually
verifies — the "only" guarantee comes from the iteration loop, not
this example.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent e55fa43 commit e88c19b
2 files changed
Lines changed: 53 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
5 | 11 | | |
6 | 12 | | |
7 | 13 | | |
| |||
510 | 516 | | |
511 | 517 | | |
512 | 518 | | |
513 | | - | |
| 519 | + | |
| 520 | + | |
514 | 521 | | |
515 | 522 | | |
516 | | - | |
517 | 523 | | |
518 | 524 | | |
519 | 525 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
0 commit comments