Commit 31cd41e
authored
docs: clarify rspack wrapper peer deps (#1193)
## Summary
- Clarify that importing through `shakapacker-rspack` lets pnpm/Yarn
users drop only the direct `shakapacker` dependency
- Keep the required Rspack peers and `rspack-manifest-plugin` documented
as explicit dependencies for strict package managers
- Follow-up to #1185 and
#1185 (comment)
## Validation
- `yarn prettier --check docs/common-upgrades.md
packages/shakapacker-rspack/README.md`
- `git diff --check`
- Ruby local markdown link existence check for touched docs
- `yarn test --runInBand`
- `.agents/bin/validate` progressed through RuboCop, ESLint, and gem
specs (`1197 examples, 0 failures, 6 pending`), then stopped in local
dummy browser specs because ChromeDriver supports Chrome 146 while
installed Chrome is 149. Hosted CI should verify that browser lane with
its runner browser/driver pair.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Documentation**
* Clarified Rspack upgrade guidance for apps using supplemental
packages.
* Updated instructions to explain when the direct `shakapacker`
dependency can be removed after switching config imports.
* Added clearer dependency requirements so the needed Rspack packages
and manifest plugin remain explicit.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent 57d3bf1 commit 31cd41e
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
0 commit comments