Add Babel 8 preset smoke

Author: justin808

.github/workflows/node.yml

@@ -82,8 +82,7 @@ jobs:
           git fetch origin ${{ github.event.pull_request.base.sha }}
           if git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | grep -q '^.github/workflows'; then
             echo "changed=true" >> "$GITHUB_OUTPUT"
-            response=$(curl -sf https://api.github.com/repos/rhysd/actionlint/releases/latest)
-            if [ $? -eq 0 ]; then
+            if response=$(curl -sf https://api.github.com/repos/rhysd/actionlint/releases/latest); then
               actionlint_version=$(echo "$response" | jq -r .tag_name)
               if [ -z "$actionlint_version" ]; then
                 echo "Failed to parse Actionlint version"
@@ -141,7 +140,7 @@ jobs:
             --skipLibCheck \
             --moduleResolution bundler \
             --types node \
-            *.d.ts
+            ./*.d.ts
   test:
     name: Testing
     strategy:
@@ -169,3 +168,29 @@ jobs:
 
       - name: Jest Specs
         run: yarn test
+
+  babel8-smoke:
+    name: Babel 8 smoke
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+      - name: Use Node.js 24
+        uses: actions/setup-node@v4
+        with:
+          node-version: "24.x"
+          cache: yarn
+
+      - name: Install dependencies
+        run: yarn --frozen-lockfile --non-interactive --prefer-offline
+
+      - name: Build TypeScript
+        run: yarn build
+
+      - name: Babel 8 smoke
+        run: yarn jest test/package/babel8-smoke.test.js --runInBand
+        env:
+          BABEL_ENV: production
+          RUN_BABEL8_SMOKE: "1"

test/package/babel8-smoke.test.js

@@ -0,0 +1,204 @@
+// Opt-in Babel 8 compatibility smoke.
+//
+// The normal test suite intentionally keeps repository development pins on
+// Babel 7. Enable this smoke with RUN_BABEL8_SMOKE=1 after `yarn build`; it
+// installs Babel 8 packages into a temp app and runs Webpack through
+// babel-loader 10 with Shakapacker's built Babel preset.
+
+const { spawnSync } = require("child_process")
+const fs = require("fs")
+const { createRequire } = require("module")
+const os = require("os")
+const path = require("path")
+const webpack = require("webpack")
+
+const repoRoot = path.resolve(__dirname, "../..")
+const builtPackageFiles = [
+  "package/babel/preset.js",
+  "package/utils/errorCodes.js",
+  "package/utils/errorHelpers.js",
+  "package/utils/helpers.js"
+]
+const babel8SmokePackages = [
+  "@babel/core@8.0.1",
+  "@babel/plugin-transform-runtime@8.0.1",
+  "@babel/preset-env@8.0.2",
+  "@babel/runtime@8.0.0",
+  "babel-loader@10.1.1"
+]
+const optedIn = process.env.RUN_BABEL8_SMOKE === "1"
+const coreIsBuilt = builtPackageFiles.every((file) =>
+  fs.existsSync(path.join(repoRoot, file))
+)
+
+const toolVersion = (cmd) => {
+  const r = spawnSync(cmd, ["--version"], {
+    encoding: "utf8",
+    cwd: os.tmpdir()
+  })
+  return r.status === 0 ? r.stdout.trim() : null
+}
+
+const npmVersion = toolVersion("npm")
+const hasNpm = npmVersion !== null
+const shouldRun = optedIn && coreIsBuilt && hasNpm
+
+const run = (cmd, args, options) => {
+  const r = spawnSync(cmd, args, { encoding: "utf8", ...options })
+  if (r.status !== 0) {
+    throw new Error(
+      `${cmd} ${args.join(" ")} failed in ${options.cwd}\nstdout:\n${r.stdout}\nstderr:\n${r.stderr}`
+    )
+  }
+  return r
+}
+
+const packageVersion = (appRequire, packageName) => {
+  const packageJsonPath = appRequire.resolve(`${packageName}/package.json`)
+  return appRequire(packageJsonPath).version
+}
+
+const installBuiltShakapackerPackage = (workRoot) => {
+  const packageRoot = path.join(workRoot, "node_modules/shakapacker")
+  fs.mkdirSync(packageRoot, { recursive: true })
+  fs.writeFileSync(
+    path.join(packageRoot, "package.json"),
+    JSON.stringify(
+      { name: "shakapacker", version: "0.0.0-babel8-smoke", private: true },
+      null,
+      2
+    )
+  )
+
+  builtPackageFiles.forEach((relativePath) => {
+    const targetPath = path.join(packageRoot, relativePath)
+    fs.mkdirSync(path.dirname(targetPath), { recursive: true })
+    fs.copyFileSync(path.join(repoRoot, relativePath), targetPath)
+  })
+}
+
+const runWebpack = (config) =>
+  new Promise((resolve, reject) => {
+    const compiler = webpack(config)
+    compiler.run((error, stats) => {
+      let resultError = error
+
+      if (!resultError && stats.hasErrors()) {
+        resultError = new Error(stats.toString({ all: false, errors: true }))
+      }
+
+      compiler.close((closeError) => {
+        if (closeError) {
+          reject(closeError)
+          return
+        }
+
+        if (resultError) {
+          reject(resultError)
+          return
+        }
+
+        resolve(stats)
+      })
+    })
+  })
+
+const computeSkipReason = () => {
+  if (!optedIn) return "RUN_BABEL8_SMOKE=1 not set"
+  if (!coreIsBuilt) return "shakapacker not built (run `yarn build`)"
+  if (!hasNpm) return "npm unavailable on PATH"
+  return "unknown skip reason"
+}
+
+describe("Babel 8 preset smoke (issue #1191)", () => {
+  let workRoot
+  let presetPath
+
+  beforeAll(() => {
+    if (!shouldRun) return
+
+    workRoot = fs.mkdtempSync(path.join(os.tmpdir(), "shaka-babel8-smoke-"))
+    fs.writeFileSync(
+      path.join(workRoot, "package.json"),
+      JSON.stringify({ name: "shaka-babel8-smoke", private: true }, null, 2)
+    )
+    run(
+      "npm",
+      [
+        "install",
+        "--no-audit",
+        "--no-fund",
+        "--save-dev",
+        ...babel8SmokePackages
+      ],
+      { cwd: workRoot }
+    )
+    installBuiltShakapackerPackage(workRoot)
+  }, 180000)
+
+  afterAll(() => {
+    if (!workRoot) return
+    fs.rmSync(workRoot, { recursive: true, force: true })
+  })
+
+  if (!shouldRun) {
+    test.todo(`Babel 8 smoke skipped (${computeSkipReason()})`)
+    return
+  }
+
+  test("compiles through babel-loader 10 with the Shakapacker Babel preset and Babel 8", async () => {
+    const srcDir = path.join(workRoot, "src")
+    const distDir = path.join(workRoot, "dist")
+    fs.mkdirSync(srcDir)
+    fs.writeFileSync(
+      path.join(srcDir, "index.js"),
+      "const answer = () => ({ value: 42 });\nconsole.log(answer()?.value);\n"
+    )
+
+    const appRequire = createRequire(path.join(workRoot, "package.json"))
+    presetPath = appRequire.resolve("shakapacker/package/babel/preset.js")
+    expect(packageVersion(appRequire, "@babel/core")).toBe("8.0.1")
+    expect(packageVersion(appRequire, "@babel/preset-env")).toBe("8.0.2")
+    expect(packageVersion(appRequire, "@babel/plugin-transform-runtime")).toBe(
+      "8.0.1"
+    )
+    expect(packageVersion(appRequire, "@babel/runtime")).toBe("8.0.0")
+    expect(packageVersion(appRequire, "babel-loader")).toBe("10.1.1")
+
+    await runWebpack({
+      mode: "development",
+      context: workRoot,
+      entry: path.join(srcDir, "index.js"),
+      output: {
+        path: distDir,
+        filename: "bundle.js"
+      },
+      module: {
+        rules: [
+          {
+            test: /\.js$/,
+            include: srcDir,
+            use: [
+              {
+                loader: appRequire.resolve("babel-loader"),
+                options: {
+                  cacheDirectory: false,
+                  cwd: workRoot,
+                  envName: "production",
+                  presets: [presetPath]
+                }
+              }
+            ]
+          }
+        ]
+      },
+      optimization: {
+        minimize: false
+      }
+    })
+
+    expect(fs.readFileSync(path.join(distDir, "bundle.js"), "utf8")).toContain(
+      "42"
+    )
+  }, 180000)
+})