Treat missing window Core restart as disabled

Author: sergey-goncharenko

maintenance_window/CHANGELOG.md

@@ -3,6 +3,13 @@
 All notable changes to the Maintenance Window add-on are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
+## 0.8.9
+
+- Make per-window `restart_core` optional again so existing saved
+  configurations continue to load after update.
+- Treat missing per-window `restart_core` as disabled instead of falling back to
+  the global Core restart default.
+
 ## 0.8.8
 
 - Make per-window `restart_core` explicit so app-only windows such as temporary

maintenance_window/DOCS.md

@@ -109,13 +109,9 @@ starts anything. Use this to validate your schedule safely before going live.
 When `true`, Home Assistant Core is stopped during the window and restarted
 afterward. Set to `false` if you only want to cycle apps.
 
-Set `restart_core` on each window that should stop Core. Leave it off for
-app-only windows, such as temporary SSH access.
-
-For compatibility with older configurations, the global value can still be used
-as a fallback for windows that do not define their own app actions. For safety,
-if a window defines per-window `stop_addons` or `start_addons` but omits
-`restart_core`, Core is left running.
+Set `restart_core` on each window that should stop Core. Leave it off or omit it
+for app-only windows, such as temporary SSH access. For safe upgrades from older
+configurations, missing per-window `restart_core` is treated as disabled.
 
 For safety, this option is not enough on its own. Core is only stopped when
 `restart_core` is `true`, `core_stop_confirmation` is set exactly to
@@ -276,16 +272,15 @@ A list of maintenance windows. Each entry has:
 | `name` | Friendly label used in logs. |
 | `start_time` | 24-hour `HH:MM` local time the window begins. |
 | `duration_minutes` | How long Core/apps stay stopped (1–1440). |
-| `restart_core` | Explicit per-window Core stop/restart setting. Leave off for app-only windows. |
+| `restart_core` | Optional per-window Core stop/restart setting. Leave off or omit for app-only windows. |
 | `stop_addons` | Optional per-window list of apps to stop. |
 | `start_addons` | Optional per-window list of apps to start temporarily. |
 | `days` | Optional days of week the window runs (`mon`–`sun`). Leave empty or omit it to run every day. |
 
 If `days` is empty or omitted, the window runs every day.
 
 If a window omits `stop_addons` or `start_addons`, the global setting with the
-same name is used. `restart_core` should be set explicitly per window; app-only
-windows should leave it off.
+same name is used. If a window omits `restart_core`, Core is left running.
 
 Example with two different window actions:
 

maintenance_window/config.json

@@ -1,6 +1,6 @@
 {
   "name": "Maintenance Window",
-  "version": "0.8.8",
+  "version": "0.8.9",
   "slug": "maintenance_window",
   "description": "Scheduled quiet mode: stop Home Assistant Core (and optionally selected apps) for a short maintenance window, then restart automatically.",
   "url": "https://github.com/sergey-goncharenko/ha-maintenance-window-addon/tree/main/maintenance_window",
@@ -69,7 +69,7 @@
         "name": "str",
         "start_time": "match(^([01]?[0-9]|2[0-3]):[0-5][0-9]$)",
         "duration_minutes": "int(1,1440)",
-        "restart_core": "bool",
+        "restart_core": "bool?",
         "stop_addons": [
           "str?"
         ],

maintenance_window/rootfs/usr/lib/maintenance-window/scheduler.sh

@@ -233,13 +233,8 @@ window_restart_core_enabled() {
             return 1
             ;;
         __missing__)
-            if window_has_app_action_override "${window_index}"; then
-                bashio::log.info "Window restart_core is not set but app actions are overridden; leaving Core running."
-                return 1
-            fi
-
-            bashio::config.true 'restart_core'
-            return $?
+            bashio::log.info "Window restart_core is not set; leaving Core running."
+            return 1
             ;;
         *)
             bashio::log.warning "Window restart_core has unexpected value '${value}'; leaving Core running."