Update nostr-tools so NIP-44 accepts payloads over 64 KiB (#153)

Deploying a site with a few hundred files fails at the last step:

  Creating site manifest event with: Files: 1117
  ✗ Failed to create/publish manifest: invalid plaintext size: must be
    between 1 and 65535 bytes

NIP-46 wraps each request to a remote signer in a NIP-44 payload, so the
largest event a bunker can sign is bounded by NIP-44's plaintext limit.
NIP-44 v2 raised that limit to 2^32-1 bytes using a 6-byte extended length
prefix for anything >= 65536; nostr-tools implements it from 2.23.8, but
the lockfile pinned 2.19.4, which still enforces the old 65535 cap. A
manifest carries one path tag per file, so a 1117-file site produces a
~141 KB event and cannot be signed at all -- after its blobs have already
been uploaded. Deploys signed with a local key were unaffected, since
nothing is encrypted in that path.

nostr-tools 2.24.1 brings @noble/curves 2.x, which no longer accepts a hex
string where a Uint8Array is expected. Two tests constructed SimpleSigner
that way; src/ already passes bytes.

Author: alexgleason

deno.lock

@@ -0,0 +1,37 @@
+import { assertEquals } from "@std/assert";
+import * as nip44 from "npm:nostr-tools/nip44";
+import { generateSecretKey, getPublicKey } from "npm:nostr-tools/pure";
+
+/**
+ * NIP-46 wraps every request to a remote signer in a NIP-44 payload, so the
+ * largest event nsyte can have a bunker sign is bounded by NIP-44's plaintext
+ * limit. NIP-44 v2 raised that to 2^32-1 bytes with a 6-byte extended length
+ * prefix (`[0x00, 0x00][u32]`) for anything >= 65536; before that it was
+ * capped at 65535.
+ *
+ * A site manifest (kind 35128) carries one `path` tag per file, so a site of a
+ * few hundred files clears 64 KiB easily -- a 1117-file site produces a
+ * ~141 KB event. Against an implementation that still enforces the old cap,
+ * every such deploy fails at the last step with "invalid plaintext size: must
+ * be between 1 and 65535 bytes", after the upload has already happened.
+ *
+ * This guards the resolved nostr-tools version rather than code in this repo:
+ * a lockfile that drifts back to a pre-extended-prefix release reintroduces
+ * the failure silently.
+ */
+Deno.test("NIP-44 round-trips payloads larger than the old 65535-byte cap", () => {
+  const conversationKey = nip44.getConversationKey(
+    generateSecretKey(),
+    getPublicKey(generateSecretKey()),
+  );
+
+  // 65535 is the last size the 2-byte u16 prefix covers; 65536 is the first
+  // that needs the extended prefix, and is where the old implementation threw.
+  // 141397 is the size of a real 1117-file manifest.
+  for (const size of [65535, 65536, 141397]) {
+    const plaintext = "a".repeat(size);
+    const decrypted = nip44.decrypt(nip44.encrypt(plaintext, conversationKey), conversationKey);
+    assertEquals(decrypted.length, size, `NIP-44 failed to round-trip ${size} bytes`);
+    assertEquals(decrypted, plaintext);
+  }
+});

tests/unit/nip44_large_payload_test.ts

@@ -1,15 +1,14 @@
 import { assertEquals } from "@std/assert";
 import { beforeAll, describe, it } from "@std/testing/bdd";
 import { SimpleSigner } from "applesauce-signers";
-import { encodeHex } from "@std/encoding/hex";
 import { createDeleteEvent } from "../../src/lib/nostr.ts";
 
 let signer: SimpleSigner;
 
 beforeAll(async () => {
   const privKeyBytes = new Uint8Array(32);
   crypto.getRandomValues(privKeyBytes);
-  signer = new SimpleSigner(encodeHex(privKeyBytes));
+  signer = new SimpleSigner(privKeyBytes);
   await signer.getPublicKey();
 });
 

tests/unit/timestamp_exclusion_test.ts

@@ -1,7 +1,6 @@
 import { assertEquals } from "@std/assert";
 import { beforeAll, describe, it } from "@std/testing/bdd";
 import { SimpleSigner } from "applesauce-signers";
-import { encodeHex } from "@std/encoding/hex";
 import {
   createAppHandlerEvent,
   createAppRecommendationEvent,
@@ -21,7 +20,7 @@ let pubkey: string;
 beforeAll(async () => {
   const privKeyBytes = new Uint8Array(32);
   crypto.getRandomValues(privKeyBytes);
-  signer = new SimpleSigner(encodeHex(privKeyBytes));
+  signer = new SimpleSigner(privKeyBytes);
   pubkey = await signer.getPublicKey();
 });