feat(routeFinder): selettore 'ottimizza per' end-to-end + cleanup post-merge

Nuova feature
---------------
- Aggiunto selettore pill 'ottimizza per' (tempo/cambi/a piedi) nella
  pagina route-finder con persistenza su localStorage.
- searchState.optimize viene propagato a /api/plan-route via query param.
- ApiController::planRoute() applica il sort dopo il post-processing
  delle walking legs:
    * transfers: route diretti prima, tie-break su duration
    * walking: somma distanze leg walking, tie-break su duration
    * time: ordine nativo del RoutePlanner
- StopCard.js: hardening con String(stop.id) per evitare TypeError su id
  numerici.
- stationSelector.css: stato visuale .stop-card.selected con check verde.

Cleanup post-merge
------------------
- public/sw.js: pre-cache aggiornato con notifications.js, widget.js,
  delayHistory.js, offline.js, delayStats.css per supporto offline
  completo delle nuove pagine introdotte dalle PR #5/#6/#8/#9.
- public/routes.php: rotte riorganizzate in 3 sezioni (Pagine, API,
  API GTFS) per leggibilita'.
- ApiController::planRoute(): rimossi commenti rumorosi lasciati
  dall'agente AI durante il refactoring iniziale.
- composer.json: aggiunto script 'composer test' -> pest.
- .phpunit.cache/test-results: rimosso dal tracking (era gia' in
  .gitignore ma tracciato per errore).
- app/views/home.php.backup: file backup eliminato.

Documentazione
--------------
- README.md: aggiunta sezione TODO con problemi noti prioritizzati
  emersi dall'analisi del codice (push reali, widget CORS, format
  adapter gtfs-passages, console.log debug, ecc.).

Author: samuele-brusegan

.phpunit.cache/test-results

@@ -0,0 +1,88 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+**actv-live** is a web application for Venice's public transport (ACTV). It provides real-time bus/water bus tracking, route planning, and stop information using GTFS data. The app is built with plain PHP (no framework) and vanilla JavaScript.
+
+## Tech Stack
+
+- **Backend**: PHP 8.4+ (plain PHP, no framework)
+- **Frontend**: Vanilla JavaScript, no build tool
+- **Database**: MySQL (GTFS data stored in tables: `stops`, `routes`, `trips`, `stop_times`, `calendar`, `shapes_refined`, `logs`)
+- **Testing**: Pest (PHP) + Jest (JavaScript)
+- **Dependencies**: Composer (Pest, symfony/var-dumper), npm (Jest, jest-environment-jsdom)
+
+## Key Commands
+
+```bash
+# Install dependencies
+composer install
+npm install
+
+# Run PHP tests (Pest)
+vendor/bin/pest
+
+# Run a single PHP test
+vendor/bin/pest tests/Unit/RouterTest.php
+
+# Run JavaScript tests (Jest)
+npm test
+
+# Run a single JS test
+npx jest --testPathPattern=routeFinder
+```
+
+## Architecture
+
+### Request Flow
+
+1. `public/index.php` — entry point, starts session, creates Router
+2. `public/routes.php` — defines all routes (URL → controller + action)
+3. `public/functions.php` / `public/imports.php` — utility functions and common imports
+4. `app/Router.php` — simple URL-keyed router that instantiates controllers and calls actions
+5. Controllers load views from `app/views/`
+
+### Directory Structure
+
+```
+app/
+  controllers/    Controller.php (page rendering), ApiController.php (JSON API endpoints)
+  models/         databaseConnector.php (PDO singleton), GTFS models (gtfsStops, gtfsPassages, etc.)
+  services/       Logger.php (DB logging), RoutePlanner.php (GTFS-based routing), GTFSParser.php
+  views/          PHP templates for each page (home, routeFinder, stopList, admin/*, etc.)
+public/
+  index.php       Entry point
+  routes.php      Route definitions
+  functions.php   Global helper functions
+  js/             Client-side JS per page (routeFinder.js, liveBusMap.js, etc.)
+  components/     Reusable JS components (StopCard.js, StopListItem.js)
+tests/
+  Unit/           PHP unit tests (Pest)
+  Feature/        Feature tests (Pest)
+  jest/           JavaScript tests (Jest)
+data/gtfs/cache/  Parsed GTFS JSON cache (stops.json, routes.json, stop_times per route)
+scripts/          CLI utilities for GTFS processing and DB management
+```
+
+### Key Components
+
+- **Router**: Simple array-based router in `app/Router.php`. Routes defined in `public/routes.php`.
+- **databaseConnector**: PDO singleton wrapper with prepared statements. `app/models/databaseConnector.php`.
+- **RoutePlanner**: GTFS-based route finder (direct + 1 transfer). Uses JSON cache files from `data/gtfs/cache/`, not the database. See `app/services/RoutePlanner.php`.
+- **GTFSParser**: Downloads and parses ACTV GTFS zip feed into JSON cache files. See `app/services/GTFSParser.php`.
+- **Logger**: Logs PHP/JS errors to the `logs` database table. See `app/services/Logger.php`.
+- **ApiController**: All API endpoints return JSON. Handles GTFS queries, route planning, bus positions, and error logging.
+
+### Configuration
+
+- Environment variables in `.env`: `DB_HOST`, `DB_USER`, `DB_PASS`, `DB_NAME`
+- Constants defined in `app/bootstrap.php`: `BASE_PATH`, `ENV`, `URL_PATH`
+- Session management with expiration check
+
+### CI
+
+GitHub Actions (`.github/workflows/test.yml`) runs on push/PR:
+- Jest on Node 20
+- Pest on PHP 8.4

CLAUDE.md

@@ -23,4 +23,28 @@ composer install
 
 ## Configurazione Docker
 
-[non ancora implementato]
+[non ancora implementato]
+
+## TODO / Da fare
+
+### 🔴 Priorità alta
+- [ ] **Notifiche push reali**: l'attuale implementazione (`public/js/notifications.js`) fa polling locale dell'API ACTV e mostra notifiche solo a tab aperto. Per vere push in background servono:
+  - Generazione e configurazione chiavi VAPID
+  - Endpoint `/api/push/subscribe` per salvare le subscription dei client
+  - Cron/job lato server che pusha quando rileva ritardi
+  - Chiamata `pushManager.subscribe()` in `notifications.js`
+  - In alternativa: rinominare la feature in "Avvisi ritardi (mentre l'app è aperta)"
+
+### 🟡 Priorità media
+- [ ] **Widget embed CORS**: `app/views/widget.php` chiama direttamente `https://oraritemporeale.actv.it/...`. In contesti embed su domini terzi potrebbe rompersi. Valutare proxy `/api/widget-passages` con CORS aperto.
+- [ ] **Format adapter `/api/gtfs-passages`**: in `public/js/stop.js:111` c'è un `//todo:correct format` — il fallback locale ritorna le righe raw di `stop_times` invece del formato `{line, destination, time, real}` di ACTV. Serve un mapper.
+- [ ] **Rimuovere `console.log` di debug** in produzione (sono volutamente lasciati per ora):
+  - `public/js/stop.js:237`
+  - `public/js/liveBusMap.js:317, 324, 391, 446`
+  - `app/views/stopList.php:163`
+
+### 🟢 Pulizia / quality
+- [ ] **CSS empty rulesets** pre-esistenti in `public/css/stop.css` (linee 2, 58, 79)
+- [ ] **Documentazione Docker** (sezione sopra è vuota)
+- [ ] **Pre-cache GTFS in SW**: la funzione `cacheGtfsData()` in `sw.js` è già pronta ma nessuno invia il messaggio `CACHE_GTFS` al SW
+- [ ] **Bottone widget in home**: la feature widget è scoperta solo dal pulsante share nella pagina fermata; valutare punto di accesso più visibile

README.md

@@ -95,14 +95,16 @@ function favorite() {
         require_once BASE_PATH . '/app/models/addToFavorites.php';
     }
 
-    // Moved from Controller::planRoute
     function planRoute() {
-        // This service likely uses local files (RoutePlanner), keeping as is per plan/User request scope (Controllers only)
         require_once BASE_PATH . '/app/services/RoutePlanner.php';
 
         $origin = $_GET['from'] ?? '';
         $dest = $_GET['to'] ?? '';
         $time = $_GET['time'] ?? date('H:i:s');
+        $optimize = $_GET['optimize'] ?? 'time';
+        if (!in_array($optimize, ['time', 'transfers', 'walking'], true)) {
+            $optimize = 'time';
+        }
 
         // Ensure time is in HH:MM:SS format
         if (strlen($time) == 5) {
@@ -111,12 +113,6 @@ function planRoute() {
 
         try {
             $planner = new RoutePlanner();
-            // ... Logic from Controller.php ...
-            // Since the logic is long and depends on RoutePlanner, we just copy the body.
-            // But wait, the user asked to "remove LOCAL GTFS calls" from Controllers.
-            // planRoute logic in Controller.php handles logic "around" RoutePlanner.
-
-            // Re-implementing the logic from Controller::planRoute
             $startWalk = null;
             $endWalk = null;
             $planningOrigin = $origin;
@@ -200,9 +196,34 @@ function planRoute() {
                     ];
                 }
             }
+            unset($route);
+
+            // Apply user-selected optimization sort
+            if ($optimize !== 'time') {
+                usort($routes, function($a, $b) use ($optimize) {
+                    if ($optimize === 'transfers') {
+                        $ta = ($a['type'] ?? '') === 'transfer' ? 1 : 0;
+                        $tb = ($b['type'] ?? '') === 'transfer' ? 1 : 0;
+                        if ($ta !== $tb) return $ta - $tb;
+                        return ($a['duration'] ?? 0) - ($b['duration'] ?? 0);
+                    }
+                    if ($optimize === 'walking') {
+                        $wa = 0; $wb = 0;
+                        foreach ($a['legs'] ?? [] as $l) {
+                            if (($l['type'] ?? '') === 'walking') $wa += (int)($l['distance'] ?? 0);
+                        }
+                        foreach ($b['legs'] ?? [] as $l) {
+                            if (($l['type'] ?? '') === 'walking') $wb += (int)($l['distance'] ?? 0);
+                        }
+                        if ($wa !== $wb) return $wa - $wb;
+                        return ($a['duration'] ?? 0) - ($b['duration'] ?? 0);
+                    }
+                    return 0;
+                });
+            }
 
             header('Content-Type: application/json');
-            echo json_encode(['success' => true, 'routes' => $routes]);
+            echo json_encode(['success' => true, 'routes' => $routes, 'optimize' => $optimize]);
 
         } catch (Exception $e) {
             header('Content-Type: application/json');