Skip to content

Commit 67efb07

Browse files
committed
Psalm testing: Override Attribute
1 parent 2b06142 commit 67efb07

21 files changed

Lines changed: 48 additions & 3 deletions

.github/workflows/sqlite.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@ jobs:
3333
- ubuntu-latest
3434

3535
php:
36-
- 8.1
37-
- 8.2
3836
- 8.3
37+
- 8.4
3938

4039
steps:
4140
- name: Checkout.

src/Reader/EntityReader.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ public function __construct(Select|SelectQuery $query)
7575
$this->filter = new All();
7676
}
7777

78+
#[\Override]
7879
public function getSort(): ?Sort
7980
{
8081
return $this->sorting;
@@ -83,6 +84,7 @@ public function getSort(): ?Sort
8384
/**
8485
* @psalm-mutation-free
8586
*/
87+
#[\Override]
8688
public function withLimit(?int $limit): static
8789
{
8890
/** @psalm-suppress DocblockTypeContradiction */
@@ -100,6 +102,7 @@ public function withLimit(?int $limit): static
100102
/**
101103
* @psalm-mutation-free
102104
*/
105+
#[\Override]
103106
public function withOffset(int $offset): static
104107
{
105108
$new = clone $this;
@@ -113,6 +116,7 @@ public function withOffset(int $offset): static
113116
/**
114117
* @psalm-mutation-free
115118
*/
119+
#[\Override]
116120
public function withSort(?Sort $sort): static
117121
{
118122
$new = clone $this;
@@ -127,6 +131,7 @@ public function withSort(?Sort $sort): static
127131
/**
128132
* @psalm-mutation-free
129133
*/
134+
#[\Override]
130135
public function withFilter(FilterInterface $filter): static
131136
{
132137
$new = clone $this;
@@ -143,6 +148,7 @@ public function withFilter(FilterInterface $filter): static
143148
/**
144149
* @psalm-mutation-free
145150
*/
151+
#[\Override]
146152
public function withAddedFilterHandlers(FilterHandlerInterface ...$filterHandlers): static
147153
{
148154
$new = clone $this;
@@ -155,11 +161,13 @@ public function withAddedFilterHandlers(FilterHandlerInterface ...$filterHandler
155161
return $new;
156162
}
157163

164+
#[\Override]
158165
public function count(): int
159166
{
160167
return $this->countCache->getCount();
161168
}
162169

170+
#[\Override]
163171
public function read(): iterable
164172
{
165173
if ($this->itemsCache->getCollection() === null) {
@@ -169,6 +177,7 @@ public function read(): iterable
169177
return $this->itemsCache->getCollection();
170178
}
171179

180+
#[\Override]
172181
public function readOne(): null|array|object
173182
{
174183
if (!$this->oneItemCache->isCollected()) {
@@ -186,11 +195,12 @@ public function readOne(): null|array|object
186195
/**
187196
* Get Iterator without caching
188197
*/
198+
#[\Override]
189199
public function getIterator(): Generator
190200
{
191201
yield from $this->itemsCache->getCollection() ?? $this->buildSelectQuery()->getIterator();
192202
}
193-
203+
194204
public function getSql(): string
195205
{
196206
$query = $this->buildSelectQuery();
@@ -261,16 +271,19 @@ private function normalizeSortingCriteria(array $criteria): array
261271
return $criteria;
262272
}
263273

274+
#[\Override]
264275
public function getFilter(): FilterInterface
265276
{
266277
return $this->filter;
267278
}
268279

280+
#[\Override]
269281
public function getLimit(): ?int
270282
{
271283
return $this->limit;
272284
}
273285

286+
#[\Override]
274287
public function getOffset(): int
275288
{
276289
return $this->offset;

src/Reader/FilterHandler/AllHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class AllHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return All::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
return [];

src/Reader/FilterHandler/AndXHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@
1313

1414
final class AndXHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1515
{
16+
#[\Override]
1617
public function getFilterClass(): string
1718
{
1819
return AndX::class;
1920
}
2021

22+
#[\Override]
2123
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2224
{
2325
/** @var AndX $filter */

src/Reader/FilterHandler/BetweenHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class BetweenHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return Between::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
/** @var Between $filter */

src/Reader/FilterHandler/EqualsHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class EqualsHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return Equals::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
/** @var Equals $filter */

src/Reader/FilterHandler/EqualsNullHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class EqualsNullHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return EqualsNull::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
/** @var EqualsNull $filter */

src/Reader/FilterHandler/GreaterThanHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class GreaterThanHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return GreaterThan::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
/** @var GreaterThan $filter */

src/Reader/FilterHandler/GreaterThanOrEqualHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@
1111

1212
final class GreaterThanOrEqualHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1313
{
14+
#[\Override]
1415
public function getFilterClass(): string
1516
{
1617
return GreaterThanOrEqual::class;
1718
}
1819

20+
#[\Override]
1921
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2022
{
2123
/** @var GreaterThanOrEqual $filter */

src/Reader/FilterHandler/InHandler.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212

1313
final class InHandler implements QueryBuilderFilterHandler, FilterHandlerInterface
1414
{
15+
#[\Override]
1516
public function getFilterClass(): string
1617
{
1718
return In::class;
1819
}
1920

21+
#[\Override]
2022
public function getAsWhereArguments(FilterInterface $filter, array $handlers): array
2123
{
2224
/** @var In $filter */

0 commit comments

Comments
 (0)