Skip to content

Commit aa113d5

Browse files
committed
Release 1.1.2: Fix Spotify volume and playback stop issues
1 parent 7ed7f4d commit aa113d5

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
### 1.1.2: 2026-01-13
2+
3+
* Set Spotify volume when track starts playing (fixes quieter Spotify playback)
4+
* Fix Spotify not stopping on quit or track change (pass device_id to pause)
5+
16
### 1.1.1: 2026-01-13
27

38
* Require platform-specific Spotify device, exit if not found (never cross-platform fallback)

omnishuffle/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
"""OmniShuffle - Unified music shuffler for Spotify, Pandora, and YouTube Music."""
22

3-
__version__ = "1.1.1"
3+
__version__ = "1.1.2"

omnishuffle/player.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ def play(self, track: Track):
101101
self._loading = True
102102

103103
# Stop current playback before starting new track
104-
if self._spotify_source:
105-
self._spotify_source.pause_playback()
104+
if self._spotify_source and self._spotify_device_id:
105+
self._spotify_source.pause_playback(self._spotify_device_id)
106106
try:
107107
self.mpv.command('stop')
108108
except Exception:
@@ -153,6 +153,8 @@ def play(self, track: Track):
153153
# Start local timer for position tracking
154154
self._spotify_start_time = time.time()
155155
self._spotify_paused_position = 0.0
156+
# Set volume on Spotify device
157+
self._spotify_source.set_volume(self._current_volume, self._spotify_device_id)
156158
return
157159

158160
# Play via mpv (YouTube search for Spotify, direct URL for others)
@@ -316,8 +318,8 @@ def on_time_update(self, callback: Callable):
316318
def shutdown(self):
317319
"""Clean shutdown."""
318320
# Stop Spotify Connect playback
319-
if self._spotify_source:
320-
self._spotify_source.pause_playback()
321+
if self._spotify_source and self._spotify_device_id:
322+
self._spotify_source.pause_playback(self._spotify_device_id)
321323
# Stop and terminate mpv
322324
try:
323325
self.mpv.command('stop')

0 commit comments

Comments
 (0)