Skip to content

Commit 91d28d2

Browse files
committed
Set more sensible defaults for file system and BLE adv interval
1 parent 5081047 commit 91d28d2

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

components/BLEManager/BLEConfig.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ class BLEConfig
7373
static const uint32_t DEFAULT_LL_PACKET_LENGTH = 251;
7474
static const uint32_t DEFAULT_SCAN_INTERVAL_MS = 200;
7575
static const uint32_t DEFAULT_SCAN_WINDOW_MS = 150;
76+
static const uint32_t DEFAULT_ADVERTISING_INTERVAL_MS = 250;
7677

7778
bool setup(const RaftJsonIF& config)
7879
{
@@ -98,7 +99,7 @@ class BLEConfig
9899
connLatencyPref = config.getLong("connLatencyPref", DEFAULT_CONN_LATENCY);
99100

100101
// Advertising
101-
advertisingIntervalMs = config.getLong("advIntervalMs", 0);
102+
advertisingIntervalMs = config.getLong("advIntervalMs", DEFAULT_ADVERTISING_INTERVAL_MS);
102103
advManufData = config.getString("advManufData", "");
103104
advManufTotalByteLimit = config.getLong("advManufValueBytes", 0);
104105
advManufValue = config.getString("advManufValue", "");

components/FileManager/FileManager.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@ void FileManager::setup()
4444
void FileManager::applySetup()
4545
{
4646
// Config settings
47-
String localFsDefaultName = configGetString("LocalFsDefault", "");
47+
String localFsDefaultName = configGetString("LocalFsDefault", "littlefs");
4848
FileSystem::LocalFileSystemType localFsTypeDefault = FileSystem::LOCAL_FS_DISABLE;
4949
if (localFsDefaultName.equalsIgnoreCase("spiffs"))
5050
localFsTypeDefault = FileSystem::LOCAL_FS_SPIFFS;
5151
else if (localFsDefaultName.equalsIgnoreCase("littlefs"))
5252
localFsTypeDefault = FileSystem::LOCAL_FS_LITTLEFS;
53-
bool localFsFormatIfCorrupt = configGetBool("LocalFsFormatIfCorrupt", false);
53+
bool localFsFormatIfCorrupt = configGetBool("LocalFsFormatIfCorrupt", true);
5454
bool enableSD = configGetBool("SDEnabled", false);
5555
bool defaultToSDIfAvailable = configGetBool("DefaultSD", false);
5656
bool cacheFileSystemInfo = configGetBool("CacheFileSysInfo", false);

0 commit comments

Comments
 (0)