Fix regression bug in ActivityItemPrompt handling

Author: softwarenerd

src/vs/workbench/contrib/positronConsole/browser/components/activityPrompt.tsx

@@ -7,7 +7,7 @@
 import './activityPrompt.css';
 
 // React.
-import { KeyboardEvent, useCallback, useEffect, useRef } from 'react';
+import { KeyboardEvent, useCallback, useEffect, useRef, useState } from 'react';
 
 // Other dependencies.
 import { Emitter } from '../../../../../base/common/event.js';
@@ -61,9 +61,31 @@ export const ActivityPrompt = (props: ActivityPromptProps) => {
 	const editorContainerRef = useRef<HTMLDivElement>(null);
 	const editorRef = useRef<CodeEditorWidget | null>(null);
 
-	// Whether to use the password input (HTML input) or the editor (CodeEditorWidget).
+	// State hooks.
+	const [state, setState] = useState(props.activityItemPrompt.state);
+
+	// State change useEffect. Subscribes to prompt state changes and updates local state to trigger re-render.
+	useEffect(() => {
+		// Create a disposable store for the prompt state change subscription, and clean it up on unmount or when the prompt changes.
+		const disposableStore = new DisposableStore();
+
+		// Subscribe to prompt state changes and update local state to trigger re-render.
+		disposableStore.add(props.activityItemPrompt.onStateChanged(() => {
+			setState(props.activityItemPrompt.state);
+		}));
+
+		// Re-sync in case the state changed between render and this effect running.
+		setState(props.activityItemPrompt.state);
+
+		// Clean up subscription on unmount or when prompt changes.
+		return () => disposableStore.dispose();
+	}, [props.activityItemPrompt]);
+
+	// A value that indicates whether to use the password input (HTML input) or the editor (CodeEditorWidget).
 	const isPassword = props.activityItemPrompt.password;
-	const isUnanswered = props.activityItemPrompt.state === ActivityItemPromptState.Unanswered;
+
+	// A value that indicates whether the prompt is currently unanswered.
+	const isUnanswered = state === ActivityItemPromptState.Unanswered;
 
 	/**
 	 * Focuses the appropriate input element.
@@ -312,7 +334,7 @@ export const ActivityPrompt = (props: ActivityPromptProps) => {
 
 	// Determine what to render based on prompt state.
 	let prompt;
-	switch (props.activityItemPrompt.state) {
+	switch (state) {
 		// When the prompt is unanswered, render the appropriate input.
 		case ActivityItemPromptState.Unanswered:
 			if (isPassword) {

src/vs/workbench/services/positronConsole/browser/classes/activityItemPrompt.ts

@@ -1,8 +1,9 @@
 /*---------------------------------------------------------------------------------------------
- *  Copyright (C) 2023-2025 Posit Software, PBC. All rights reserved.
+ *  Copyright (C) 2023-2026 Posit Software, PBC. All rights reserved.
  *  Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import { Emitter } from '../../../../../base/common/event.js';
 import { ActivityItem, TrimScrollbackResult } from './activityItem.js';
 import { formatOutputLinesForClipboard } from '../utils/clipboardUtils.js';
 import { ANSIOutput, ANSIOutputLine } from '../../../../../base/common/ansiOutput.js';
@@ -20,17 +21,43 @@ export const enum ActivityItemPromptState {
  * ActivityItemPrompt class.
  */
 export class ActivityItemPrompt extends ActivityItem {
+	//#region Private Properties
+
+	/**
+	 * The state of the prompt.
+	 */
+	private _state = ActivityItemPromptState.Unanswered;
+
+	/**
+	 * An emitter that fires when the state of the prompt changes.
+	 */
+	private readonly _onStateChangedEmitter = new Emitter<void>();
+
+	//#endregion Private Properties
+
 	//#region Public Properties
 
 	/**
-	 * Gets the output lines.
+	 * Gets the state.
 	 */
-	readonly outputLines: readonly ANSIOutputLine[];
+	get state() {
+		return this._state;
+	}
 
 	/**
-	 * Gets or sets the state.
+	 * Sets the state.
 	 */
-	state = ActivityItemPromptState.Unanswered;
+	set state(state: ActivityItemPromptState) {
+		if (state !== this._state) {
+			this._state = state;
+			this._onStateChangedEmitter.fire();
+		}
+	}
+
+	/**
+	 * Gets the output lines.
+	 */
+	readonly outputLines: readonly ANSIOutputLine[];
 
 	/**
 	 * Gets or sets the answer.
@@ -39,6 +66,15 @@ export class ActivityItemPrompt extends ActivityItem {
 
 	//#endregion Public Properties
 
+	//#region Public Events
+
+	/**
+	 * An event that fires when the state changes.
+	 */
+	public onStateChanged = this._onStateChangedEmitter.event;
+
+	//#endregion Public Events
+
 	//#region Constructor
 
 	/**