Skip to content

Out of the box "sticky" is broken by several of the components #668

Description

@ishaisagi-hns

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.23 ]

Expected / Desired Behavior / Question

Components should not interfere with Microsoft out of the box webparts

Observed Behavior

When a custom webpart using some of a @pnp/spfx-property-controls component (I am researching if its a specific one or not) the result is that the microsoft "text" webpart's toolbar menu stops being "sticky" as you scroll down the page - forcing the user to scroll to the top of the webpart to use the editing menu.
This happens even if the property pane for the custom webpart is not open. This resolves when custom webpart is removed from the page. This is also resolves if the custom property control is loaded "lazy" (dynamic loading) rather than with a "import" statement.

Steps to Reproduce

  1. create a custom webpart, with a custom property pane, and add a PropertyFieldNumber, PropertyPaneWebPartInformation to it.
    import { PropertyFieldNumber, PropertyPaneWebPartInformation } from '@pnp/spfx-property-controls';

2, add the webpart to a page, and on the same page add a text webpart and write a lot of rows in it so that to see the bottom of it you have to scroll down the page
3. put cursor at the bottom of text webpart - note how the menubar (toolbar) for editing the text is not showing, unless you scroll back to top of the webpart.

note - I am currently testing if doing a "Deep import" fixes this and will update tomorrow:
import { PropertyFieldNumber } from '@pnp/spfx-property-controls/lib/PropertyFieldNumber';
import { PropertyPaneWebPartInformation } from '@pnp/spfx-property-controls/lib/PropertyPaneWebPartInformation';

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions