Merge pull request #285 from plasma-umass/ci-macos-build

ci: add macOS build job

Author: emeryberger

.github/workflows/ci.yml

@@ -237,3 +237,58 @@ jobs:
           build/profile.jsonl
           build/lock_test_profile.jsonl
         retention-days: 7
+
+  build-macos:
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Install dependencies
+      run: |
+        # cmake is preinstalled on the runner; make sure pkg-config and sqlite
+        # (needed to configure the benchmark tree) are available. coreutils
+        # provides gtimeout, since macOS has no GNU `timeout`.
+        brew install pkg-config sqlite coreutils || true
+
+    - name: Build coz
+      run: |
+        mkdir build
+        cd build
+        cmake .. -DCMAKE_BUILD_TYPE=RelWithDebInfo
+        make -j$(sysctl -n hw.ncpu)
+
+    - name: Build benchmarks
+      run: |
+        cd build
+        cmake .. -DBUILD_BENCHMARKS=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo
+        make -j$(sysctl -n hw.ncpu) toy lock_test kmeans
+
+    - name: Verify build artifacts
+      run: |
+        # On macOS the injectable library keeps the .so suffix (see
+        # libcoz/CMakeLists.txt) so it can be used with DYLD_INSERT_LIBRARIES.
+        test -f build/libcoz/libcoz.so
+        test -x build/benchmarks/toy/toy
+        test -x build/benchmarks/lock_test/lock_test
+        test -x build/benchmarks/kmeans/kmeans
+        echo "Build artifacts verified"
+
+    - name: Run unit tests
+      run: |
+        cd build
+        # Includes test_run_kmeans, which profiles kmeans live via kperf and so
+        # also validates that macOS sampling actually collects samples.
+        ctest --output-on-failure -j$(sysctl -n hw.ncpu)
+        echo "Unit tests passed"
+
+    - name: Run toy benchmark with coz
+      run: |
+        cd build
+        gtimeout 30 ../coz run -o profile.jsonl --- ./benchmarks/toy/toy || true
+        if [ ! -s profile.jsonl ]; then
+          echo "ERROR: profile.jsonl was not created"
+          exit 1
+        fi
+        echo "Profile created:"
+        cat profile.jsonl

benchmarks/check-output.sh

@@ -7,5 +7,7 @@ $@
 
 grep -q '"time":' profile.jsonl || { echo failure: valid profile.jsonl not generated; exit 1; }
 grep -q '"throughput-point"' profile.jsonl || { echo failure: throughput-point not found in profile; exit 1; }
-grep -q -P '{"type":"samples","location":' profile.jsonl || { echo failure: samples not found in profile; exit 1; }
+# Use -F (fixed string) rather than -P: the pattern is a literal substring and
+# BSD grep (macOS) has no -P, which otherwise made this fail on macOS.
+grep -q -F '{"type":"samples","location":' profile.jsonl || { echo failure: samples not found in profile; exit 1; }
 echo success: benchmark generated valid profile.jsonl