Skip to content

Commit 07f0ea6

Browse files
spfresh: rename search beam request field (#420)
Rename SPFreshSearchRequest field 9 from base_beam_size to search_beam_size so TiPB matches TiDB SQL and TiKV request semantics. The wire number stays unchanged. Regenerate Go bindings and refresh proto.lock after the schema rename.
1 parent 5f9928e commit 07f0ea6

3 files changed

Lines changed: 85 additions & 67 deletions

File tree

go-tipb/spfresh_search.pb.go

Lines changed: 63 additions & 63 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/spfresh_search.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ message SPFreshSearchRequest {
3232

3333
// Optional tuning parameters.
3434
double oversample_factor = 8;
35-
// If zero, the server uses its default base beam size.
36-
uint32 base_beam_size = 9;
35+
// If zero, the server uses its default search beam size.
36+
uint32 search_beam_size = 9;
3737

3838
// read_only disables background fixups (split/merge) triggered by search
3939
// observations. When enabled, the server must not enqueue fixups and should

scripts/proto.lock

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2528,6 +2528,12 @@
25282528
"name": "runtime_filter_list",
25292529
"type": "RuntimeFilter",
25302530
"is_repeated": true
2531+
},
2532+
{
2533+
"id": 15,
2534+
"name": "is_null_eq",
2535+
"type": "bool",
2536+
"is_repeated": true
25312537
}
25322538
]
25332539
},
@@ -4462,6 +4468,18 @@
44624468
"name": "ApproxCountDistinct",
44634469
"integer": 3020
44644470
},
4471+
{
4472+
"name": "SumInt",
4473+
"integer": 3021
4474+
},
4475+
{
4476+
"name": "MinCount",
4477+
"integer": 3022
4478+
},
4479+
{
4480+
"name": "MaxCount",
4481+
"integer": 3023
4482+
},
44654483
{
44664484
"name": "RowNumber",
44674485
"integer": 4001
@@ -8502,7 +8520,7 @@
85028520
},
85038521
{
85048522
"id": 9,
8505-
"name": "base_beam_size",
8523+
"name": "search_beam_size",
85068524
"type": "uint32"
85078525
},
85088526
{
@@ -9613,4 +9631,4 @@
96139631
}
96149632
}
96159633
]
9616-
}
9634+
}

0 commit comments

Comments
 (0)