Hi,
After PR #1313, our CI started failing due to stricter typing of
DataFrame.at. This wasn’t mentioned in the PR title/description.
What changed
Impact
- CI failed immediately because our unpinned install pulled the latest version.
- The failures were surprising since the PR only mentioned adding
assert_type tests and a __new__ for DatetimeIndex.
- Users may perceive this as a “silent breaking change,” even if it’s a stubs bugfix.
Suggestion
- Please call out such changes explicitly in PR descriptions and release notes, as they can break downstream CI.
- Consider labeling them as breaking typing changes.
Refs: #1313
Hi,
After PR #1313, our CI started failing due to stricter typing of
DataFrame.at. This wasn’t mentioned in the PR title/description.What changed
.atwas loosely typed so mypy didn’t flag invalid usage..atenforces stricter signatures (correctly).intindexing without explicit narrowing.Impact
assert_typetests and a__new__forDatetimeIndex.Suggestion
Refs: #1313