Skip to content

Commit 4e62678

Browse files
committed
make populator incremental handling
make populator handling incremental fix - remove unused func refine refine refine fixes llm-d-incubation#450 fix remove duplicated call to setStatus add work queue add lock
1 parent f11a020 commit 4e62678

8 files changed

Lines changed: 1351 additions & 539 deletions

File tree

pkg/controller/common/interface.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ const (
3232
// corresponding LauncherConfig object's PodTemplate that the server-providing Pod uses.
3333
LauncherConfigHashAnnotationKey = "dual-pods.llm-d.ai/launcher-config-hash"
3434

35+
// LauncherTemplateHashAnnotationKey is the node-independent template hash on a launcher Pod, used for spec-drift detection.
36+
LauncherTemplateHashAnnotationKey = "dual-pods.llm-d.ai/launcher-populator-template-hash"
37+
3538
// LauncherServicePort is the port number on which the launcher exposes its HTTP service
3639
// for the management of vLLM instances.
3740
// This is a contract between the controllers and the launcher implementation.

pkg/controller/dual-pods/inference-server.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,11 @@ func (item infSvrItem) process(urCtx context.Context, ctl *controller, nodeDat *
589589
)
590590
}
591591

592-
desiredLauncherPod, err := utils.BuildLauncherPodFromTemplate(lc.Spec.PodTemplate, ctl.namespace, requestingPod.Spec.NodeName, lcName)
592+
desiredLauncherTemplateHash, err := utils.ComputeLauncherTemplateHash(lc.Spec.PodTemplate)
593+
if err != nil {
594+
return fmt.Errorf("failed to compute template hash for LauncherConfig %q: %w", lcName, err), true
595+
}
596+
desiredLauncherPod, err := utils.BuildLauncherPodFromTemplate(lc.Spec.PodTemplate, ctl.namespace, requestingPod.Spec.NodeName, lcName, desiredLauncherTemplateHash)
593597
if err != nil {
594598
return fmt.Errorf("failed to build launcher Pod from LauncherConfig %q: %w", lcName, err), true
595599
}

0 commit comments

Comments
 (0)