Skip to content

Commit b38537d

Browse files
authored
ci: sign automated release-update commits (#183)
## What Add `sign-commits: true` to the `peter-evans/create-pull-request` step in `.github/workflows/update-releases.yml`. ## Why The workflow currently commits via the action's default local-git path, which produces **unsigned** commits. Branch protection on `main` requires *"commits must have verified signatures"*, so the automated PRs it opens (e.g. #182) cannot be merged: ``` committer: github-actions[bot] verified: false reason: unsigned ``` With `sign-commits: true`, `create-pull-request` builds the commit through the GitHub git-data API. Commits created via the API with `GITHUB_TOKEN` are signed server-side by GitHub and show as **Verified** (attributed to `github-actions[bot]`), satisfying the requirement. No key management needed. ## Notes - Committer identity on generated commits becomes `github-actions[bot]` rather than the local git config — expected with API-created commits. - Applies to future runs. The already-open #182 can be regenerated by re-dispatching this workflow once merged (fixed branch name + `delete-branch: true` updates the PR in place). Refs #168. --------- Signed-off-by: Terry Howe <terrylhowe@gmail.com>
1 parent 6f3b32c commit b38537d

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

.github/workflows/update-releases.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,21 @@ jobs:
6868
token: ${{ secrets.GITHUB_TOKEN }}
6969
branch: automated/update-releases
7070
delete-branch: true
71+
sign-commits: true
7172
commit-message: 'chore: update releases.json for ${{ steps.update.outputs.ADDED_VERSIONS }}'
7273
title: 'chore: update releases.json for ${{ steps.update.outputs.ADDED_VERSIONS }}'
7374
body: |
74-
Automated update for new ORAS release(s): `${{ steps.update.outputs.ADDED_VERSIONS }}`.
75+
Automated update adding ORAS release(s) `${{ steps.update.outputs.ADDED_VERSIONS }}`
76+
to `src/lib/data/releases.json`, with `dist/` rebuilt to match.
7577
76-
Generated by `.github/workflows/update-releases.yml` using
77-
`.github/scripts/update-releases.mjs`. Please verify the appended
78-
entries in `src/lib/data/releases.json` and the rebuilt `dist/`
79-
before merging.
78+
Generated by `.github/workflows/update-releases.yml` via
79+
`.github/scripts/update-releases.mjs`.
80+
81+
Review checklist:
82+
- Checksums match the upstream release(s) at
83+
https://github.com/oras-project/oras/releases (the one thing not
84+
covered by CI)
85+
- `check-dist` is green — confirms `dist/` matches the rebuilt source
8086
8187
Refs #168.
8288
signoff: true

0 commit comments

Comments
 (0)