noticed this while working on the browser build — the wheel-of-destiny summary panel reads conviction perks from the wrong slots, so the skill / life leech / mana leech / spell rows end up showing shifted (or empty) data
getConvictionPerks() in modules/game_wheel/classes/bonus.lua (order map around L778) keys the convictions table like this:
special_1=1 special_2=2 special_3=3 special_4=4
skill=5 lifeleech=6 manaleech=7
spell_1..5 = 8..12
vessel.1..4 = 13..16
but the summary in modules/game_wheel/classes/wheelclass.lua reads them as:
- special_1 →
convictions[1] (L1516) ✓
- special_2 →
convictions[2] (L1528) ✓
- skill →
convictions[3] (L1540) — but skill is stored at 5, slot 3 is special_3
- life leech →
convictions[4] (L1479) — stored at 6, slot 4 is special_4
- mana leech →
convictions[5] (L1488) — stored at 7, slot 5 is skill
- spells →
convictions[_] with f_table keys 6..10 (L1559-1571) — but spells are stored at 8..12
so from skill onward everything is read 2 positions too low. the summary jumps straight from special_2 to skill and never accounts for the special_3 / special_4 slots that the order map reserves at 3/4
this is pre-existing and has nothing to do with any browser/wasm change — it just got surfaced by a bot review on #1749 (#1749 (comment))
i couldn't confirm the exact on-screen result (needs a server + a populated wheel to see it live), but the index mismatch is clearly there in the code. whoever owns the wheel code can probably tell at a glance whether skill/leech/spell should be reading 5/6/7/8-12 to line up with getConvictionPerks
noticed this while working on the browser build — the wheel-of-destiny summary panel reads conviction perks from the wrong slots, so the skill / life leech / mana leech / spell rows end up showing shifted (or empty) data
getConvictionPerks()inmodules/game_wheel/classes/bonus.lua(order map around L778) keys the convictions table like this:but the summary in
modules/game_wheel/classes/wheelclass.luareads them as:convictions[1](L1516) ✓convictions[2](L1528) ✓convictions[3](L1540) — but skill is stored at 5, slot 3 is special_3convictions[4](L1479) — stored at 6, slot 4 is special_4convictions[5](L1488) — stored at 7, slot 5 is skillconvictions[_]with f_table keys 6..10 (L1559-1571) — but spells are stored at 8..12so from
skillonward everything is read 2 positions too low. the summary jumps straight from special_2 to skill and never accounts for the special_3 / special_4 slots that the order map reserves at 3/4this is pre-existing and has nothing to do with any browser/wasm change — it just got surfaced by a bot review on #1749 (#1749 (comment))
i couldn't confirm the exact on-screen result (needs a server + a populated wheel to see it live), but the index mismatch is clearly there in the code. whoever owns the wheel code can probably tell at a glance whether skill/leech/spell should be reading 5/6/7/8-12 to line up with getConvictionPerks