Skip to content

Commit d3f3912

Browse files
Isaac SpringerIsaac Springer
authored andcommitted
chore: resolve linting issues across all tracked Python files
- Shorten line lengths in CLI arg definitions (main.py) - Add pylint file-level disables for test fixture patterns - Add missing docstring for FakeResponse test helper - Prefix unused variable names with underscore - Add missing trailing newlines - All files now score 10/10 on pylint
1 parent ce077c3 commit d3f3912

3 files changed

Lines changed: 24 additions & 12 deletions

File tree

tests/test_api_transcriber.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
"""Tests for ApiTranscriber."""
2+
# pylint: disable=redefined-outer-name,unused-argument
3+
24
from unittest.mock import MagicMock, patch
35

46
import numpy as np
@@ -19,7 +21,9 @@ def test_init(mock_openai):
1921
mock_class, _ = mock_openai
2022
from tinysteno.api_transcriber import ApiTranscriber
2123

22-
t = ApiTranscriber(api_key="test-key", base_url="https://test.example.com/v1", model="whisper-1")
24+
t = ApiTranscriber(
25+
api_key="test-key", base_url="https://test.example.com/v1", model="whisper-1"
26+
)
2327

2428
assert t.model == "whisper-1"
2529
mock_class.assert_called_once_with(
@@ -164,11 +168,13 @@ def test_language_fallback(mock_openai, tmp_path):
164168
sf.write(str(wav_path), audio, 16000)
165169

166170
class FakeResponse:
171+
"""Minimal response-like object without language attribute."""
172+
167173
text = "hello"
168174
duration = 1.0
169175

170176
client.audio.transcriptions.create.return_value = FakeResponse()
171177

172178
t = ApiTranscriber(api_key="test-key")
173179
result = t.transcribe(str(wav_path))
174-
assert result["detected_language"] == "en"
180+
assert result["detected_language"] == "en"

tests/test_transcriber.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ def test_whisper_transcriber_different_devices_separate_cache():
154154

155155
with patch("tinysteno.transcriber.WhisperModel") as mock_wm:
156156
mock_wm.return_value = MagicMock()
157-
t1 = mod.WhisperTranscriber(model_size="tiny", device="cpu", compute_type="int8")
158-
t2 = mod.WhisperTranscriber(model_size="tiny", device="cuda", compute_type="float16")
157+
_t1 = mod.WhisperTranscriber(model_size="tiny", device="cpu", compute_type="int8")
158+
_t2 = mod.WhisperTranscriber(model_size="tiny", device="cuda", compute_type="float16")
159159

160160
# Two different cache keys → two WhisperModel constructor calls
161161
assert mock_wm.call_count == 2
@@ -168,4 +168,4 @@ def test_detect_device_returns_tuple():
168168
device, compute_type = _detect_device()
169169
assert isinstance(device, str)
170170
assert isinstance(compute_type, str)
171-
assert device in ("cpu", "cuda", "auto")
171+
assert device in ("cpu", "cuda", "auto")

tinysteno/main.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -663,20 +663,26 @@ def main():
663663
record_parser.add_argument("--verbose", action="store_true", help="Verbose output")
664664
record_parser.add_argument("--backend", choices=["local", "api"], help="Transcription backend")
665665
record_parser.add_argument("--whisper-device", help="Whisper device override (cpu, cuda, auto)")
666-
record_parser.add_argument("--whisper-compute-type", help="Whisper compute type override (int8, float16, auto)")
667-
record_parser.add_argument("--whisper-api-key", help="API key for API transcription backend")
668-
record_parser.add_argument("--whisper-api-model", help="Model name for API transcription backend")
666+
record_parser.add_argument(
667+
"--whisper-compute-type",
668+
help="Whisper compute type (int8, float16, auto)",
669+
)
670+
record_parser.add_argument("--whisper-api-key", help="API key for API backend")
671+
record_parser.add_argument("--whisper-api-model", help="Model name for API backend")
669672

670673
process_parser = subparsers.add_parser("process", help="Process existing audio")
671674
process_parser.add_argument("audio", help="Audio file path")
672675
process_parser.add_argument("--name", help="Meeting name")
673676
process_parser.add_argument("--persona", help="Persona slug to use for this audio file")
674677
process_parser.add_argument("--verbose", action="store_true", help="Verbose output")
675678
process_parser.add_argument("--backend", choices=["local", "api"], help="Transcription backend")
676-
process_parser.add_argument("--whisper-device", help="Whisper device override (cpu, cuda, auto)")
677-
process_parser.add_argument("--whisper-compute-type", help="Whisper compute type override (int8, float16, auto)")
678-
process_parser.add_argument("--whisper-api-key", help="API key for API transcription backend")
679-
process_parser.add_argument("--whisper-api-model", help="Model name for API transcription backend")
679+
process_parser.add_argument("--whisper-device", help="Whisper device (cpu, cuda, auto)")
680+
process_parser.add_argument(
681+
"--whisper-compute-type",
682+
help="Whisper compute type (int8, float16, auto)",
683+
)
684+
process_parser.add_argument("--whisper-api-key", help="API key for API backend")
685+
process_parser.add_argument("--whisper-api-model", help="Model name for API backend")
680686

681687
list_parser = subparsers.add_parser("list", help="List meetings")
682688
list_parser.add_argument("--vault", default="", help="Vault path")

0 commit comments

Comments
 (0)