Skip to content

suggestion: include opponent name in the AI analysis ready notification #3602

Description

@teauxfu

These notifications would be easier for the user to scan at a glance if they included the opponent's name

Image

Here's where we construct that

case "aiReviewDone":
return (
<div>
{interpolate(
_("The computer has finished analyzing your game: {{game_name}}"),
{
game_name: notification.game_name,
},
)}
</div>
);

However, there's no obvious game info on the notification itself

interface NotificationEntryProps {
notification: Notification;
}

I'm assuming this last prop is some kind of open dictionary, and the server just puts whatever it thinks is relevant inside? I'm not sure where to take it from there exactly, maybe someone more familiar with the codebase could comment? Would supporting this require API changes?

export interface Notification {
id: string;
type: string;
[k: string]: any;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions