These notifications would be easier for the user to scan at a glance if they included the opponent's name
Here's where we construct that
|
case "aiReviewDone": |
|
return ( |
|
<div> |
|
{interpolate( |
|
_("The computer has finished analyzing your game: {{game_name}}"), |
|
{ |
|
game_name: notification.game_name, |
|
}, |
|
)} |
|
</div> |
|
); |
However, there's no obvious game info on the notification itself
|
interface NotificationEntryProps { |
|
notification: Notification; |
|
} |
I'm assuming this last prop is some kind of open dictionary, and the server just puts whatever it thinks is relevant inside? I'm not sure where to take it from there exactly, maybe someone more familiar with the codebase could comment? Would supporting this require API changes?
|
export interface Notification { |
|
id: string; |
|
type: string; |
|
[k: string]: any; |
|
} |
These notifications would be easier for the user to scan at a glance if they included the opponent's name
Here's where we construct that
online-go.com/src/components/Notifications/Notifications.tsx
Lines 553 to 563 in 1c52f40
However, there's no obvious game info on the notification itself
online-go.com/src/components/Notifications/Notifications.tsx
Lines 80 to 82 in 1c52f40
I'm assuming this last prop is some kind of open dictionary, and the server just puts whatever it thinks is relevant inside? I'm not sure where to take it from there exactly, maybe someone more familiar with the codebase could comment? Would supporting this require API changes?
online-go.com/src/components/Notifications/NotificationManager.tsx
Lines 38 to 42 in 1c52f40