Allow empty release asset suffix

Author: PerishCode

.github/workflow/scripts/release/prepare-platform-assets.ps1

@@ -11,6 +11,7 @@ param(
   [Parameter(Mandatory = $true)]
   [string]$ReleaseVersion,
   [Parameter(Mandatory = $true)]
+  [AllowEmptyString()]
   [string]$ReleaseAssetSuffix,
   [Parameter(Mandatory = $true)]
   [string]$ReleaseChannel,

.github/workflow/scripts/release/prepare-platform-assets.sh

@@ -20,14 +20,15 @@ sha256_file() {
 }
 
 required RELEASE_ASSETS_DIR
-required RELEASE_ASSET_SUFFIX
 required RELEASE_CHANNEL
 required RELEASE_NAMESPACE
 required RELEASE_PUBLIC_ORIGIN
 required RELEASE_TARGET
 required RELEASE_VERSION
 required TOOLS_PACK_DIR
 
+RELEASE_ASSET_SUFFIX="${RELEASE_ASSET_SUFFIX:-}"
+
 mkdir -p "$RELEASE_ASSETS_DIR"
 
 case "$RELEASE_TARGET" in

tools/pack/tests/release-workflows.test.ts

@@ -16,13 +16,14 @@ function countOccurrences(content: string, needle: string): number {
 
 describe("release workflows", () => {
   it("requires Vela CLI only for beta mac arm64 packaging", async () => {
-    const [beta, betaSelfHosted, preview, stable, buildMac, buildWin, prepareWin, publishPlatform] = await Promise.all([
+    const [beta, betaSelfHosted, preview, stable, buildMac, buildWin, prepareMac, prepareWin, publishPlatform] = await Promise.all([
       readFile(new URL("../../../.github/workflows/release-beta.yml", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflows/release-beta-s.yml", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflows/release-preview.yml", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflows/release-stable.yml", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflow/scripts/release/build-platform.sh", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflow/scripts/release/build-platform.ps1", import.meta.url), "utf8"),
+      readFile(new URL("../../../.github/workflow/scripts/release/prepare-platform-assets.sh", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflow/scripts/release/prepare-platform-assets.ps1", import.meta.url), "utf8"),
       readFile(new URL("../../../.github/workflow/scripts/release/storage/publish-platform.ts", import.meta.url), "utf8"),
     ]);
@@ -72,6 +73,9 @@ describe("release workflows", () => {
     expect(betaSelfHosted).toContain("summary-metadata.ts");
     expect(win).toContain("-IncludeZip $${{ inputs.win_x64_target == 'all' || inputs.win_x64_target == 'zip' }}");
     expect(selfHostedWin).toContain("-IncludeZip $${{ inputs.win_x64_target == 'all' || inputs.win_x64_target == 'zip' }}");
+    expect(prepareMac).not.toContain("required RELEASE_ASSET_SUFFIX");
+    expect(prepareMac).toContain('RELEASE_ASSET_SUFFIX="${RELEASE_ASSET_SUFFIX:-}"');
+    expect(prepareWin).toContain("[AllowEmptyString()]");
     expect(prepareWin).toContain("$sourcePayload = [string]$build.payloadPath");
     expect(prepareWin).toContain("open-design-$ReleaseVersion$ReleaseAssetSuffix-win-x64-payload.7z");
     expect(publishPlatform).toContain("open-design-${releaseVersion}${assetSuffix}-win-x64-payload.7z");