feat(i18n): extract agent manager messages

Author: TJ Webb

code_puppy/agents/agent_manager.py

@@ -16,6 +16,7 @@
 from code_puppy.agents.base_agent import BaseAgent
 from code_puppy.agents.json_agent import JSONAgent, discover_json_agents
 from code_puppy.callbacks import on_agent_reload, on_register_agents
+from code_puppy.i18n import t
 from code_puppy.messaging import emit_success, emit_warning
 from code_puppy.tools.common import atomic_write_text
 
@@ -288,7 +289,7 @@ def _discover_agents_locked(message_group_id: Optional[str] = None):
         except Exception as e:
             # Skip problematic modules
             emit_warning(
-                f"Warning: Could not load agent module {modname}: {e}",
+                t("agent_manager.discovery.module_load_failed", modname=modname, error=e),
                 message_group=message_group_id,
             )
             continue
@@ -330,14 +331,14 @@ def _discover_agents_locked(message_group_id: Optional[str] = None):
 
                 except Exception as e:
                     emit_warning(
-                        f"Warning: Could not load agent {subpkg_name}.{modname}: {e}",
+                        t("agent_manager.discovery.agent_load_failed", agent=f"{subpkg_name}.{modname}", error=e),
                         message_group=message_group_id,
                     )
                     continue
 
         except Exception as e:
             emit_warning(
-                f"Warning: Could not load agent sub-package {subpkg_name}: {e}",
+                t("agent_manager.discovery.subpackage_load_failed", subpackage=subpkg_name, error=e),
                 message_group=message_group_id,
             )
             continue
@@ -356,15 +357,15 @@ def _discover_agents_locked(message_group_id: Optional[str] = None):
                 if agent_name not in _WARNED_JSON_SHADOWED:
                     _WARNED_JSON_SHADOWED.add(agent_name)
                     emit_warning(
-                        f"JSON agent '{agent_name}' skipped: builtin Python agent with the same name takes precedence.",
+                        t("agent_manager.discovery.json_shadowed", agent_name=agent_name),
                         message_group=message_group_id,
                     )
                 continue
             _AGENT_REGISTRY[agent_name] = json_path
 
     except Exception as e:
         emit_warning(
-            f"Warning: Could not discover JSON agents: {e}",
+            t("agent_manager.discovery.json_discovery_failed", error=e),
             message_group=message_group_id,
         )
 
@@ -396,7 +397,7 @@ def _discover_agents_locked(message_group_id: Optional[str] = None):
 
     except Exception as e:
         emit_warning(
-            f"Warning: Could not load plugin agents: {e}",
+            t("agent_manager.discovery.plugin_load_failed", error=e),
             message_group=message_group_id,
         )
 
@@ -684,7 +685,7 @@ def clone_agent(agent_name: str) -> Optional[str]:
 
     agent_ref = _AGENT_REGISTRY.get(agent_name)
     if agent_ref is None:
-        emit_warning(f"Agent '{agent_name}' not found for cloning.")
+        emit_warning(t("agent_manager.clone.source_not_found", agent_name=agent_name))
         return None
 
     from ..config import get_agent_pinned_model, get_user_agents_directory
@@ -746,22 +747,22 @@ def clone_agent(agent_name: str) -> Optional[str]:
             if pinned_model:
                 clone_config["model"] = pinned_model
     except Exception as exc:
-        emit_warning(f"Failed to build clone for '{agent_name}': {exc}")
+        emit_warning(t("agent_manager.clone.build_failed", agent_name=agent_name, error=exc))
         return None
 
     if clone_path.exists():
-        emit_warning(f"Clone target '{clone_name}' already exists.")
+        emit_warning(t("agent_manager.clone.target_exists", clone_name=clone_name))
         return None
 
     try:
         atomic_write_text(
             str(clone_path),
             json.dumps(clone_config, indent=2, ensure_ascii=False),
         )
-        emit_success(f"Cloned '{agent_name}' to '{clone_name}'.")
+        emit_success(t("agent_manager.clone.success", agent_name=agent_name, clone_name=clone_name))
         return clone_name
     except Exception as exc:
-        emit_warning(f"Failed to write clone file '{clone_path}': {exc}")
+        emit_warning(t("agent_manager.clone.write_failed", clone_path=clone_path, error=exc))
         return None
 
 
@@ -778,40 +779,40 @@ def delete_clone_agent(agent_name: str) -> bool:
     _discover_agents(message_group_id=message_group_id)
 
     if not is_clone_agent_name(agent_name):
-        emit_warning(f"Agent '{agent_name}' is not a clone.")
+        emit_warning(t("agent_manager.delete.not_clone", agent_name=agent_name))
         return False
 
     if get_current_agent_name() == agent_name:
-        emit_warning("Cannot delete the active agent. Switch agents first.")
+        emit_warning(t("agent_manager.delete.active_agent"))
         return False
 
     agent_ref = _AGENT_REGISTRY.get(agent_name)
     if agent_ref is None:
-        emit_warning(f"Clone '{agent_name}' not found.")
+        emit_warning(t("agent_manager.delete.not_found", agent_name=agent_name))
         return False
 
     if not isinstance(agent_ref, str):
-        emit_warning(f"Clone '{agent_name}' is not a JSON agent.")
+        emit_warning(t("agent_manager.delete.not_json", agent_name=agent_name))
         return False
 
     clone_path = Path(agent_ref)
     if not clone_path.exists():
-        emit_warning(f"Clone file for '{agent_name}' does not exist.")
+        emit_warning(t("agent_manager.delete.file_not_found", agent_name=agent_name))
         return False
 
     from ..config import get_user_agents_directory
 
     agents_dir = Path(get_user_agents_directory()).resolve()
     if clone_path.resolve().parent != agents_dir:
-        emit_warning(f"Refusing to delete non-user clone '{agent_name}'.")
+        emit_warning(t("agent_manager.delete.non_user", agent_name=agent_name))
         return False
 
     try:
         clone_path.unlink()
-        emit_success(f"Deleted clone '{agent_name}'.")
+        emit_success(t("agent_manager.delete.success", agent_name=agent_name))
         _AGENT_REGISTRY.pop(agent_name, None)
         _AGENT_HISTORIES.pop(agent_name, None)
         return True
     except Exception as exc:
-        emit_warning(f"Failed to delete clone '{agent_name}': {exc}")
+        emit_warning(t("agent_manager.delete.failed", agent_name=agent_name, error=exc))
         return False

code_puppy/i18n/locales/en-US.json

@@ -349,5 +349,24 @@
   "model_menu.browser.unsupported_provider": "Cannot add model from {provider}: {reason}",
   "model_menu.browser.no_tool_call_warning": "⚠️  {model} does NOT support tool calling!\n   This model won't be able to edit files, run commands, or use any tools.\n   It will be very limited for coding tasks.",
   "model_menu.browser.add_cancelled": "Model addition cancelled.",
-  "cli.autosave.tui_required": "Interactive session browsing needs a terminal. Use -r NAME to resume a session by name."
+  "cli.autosave.tui_required": "Interactive session browsing needs a terminal. Use -r NAME to resume a session by name.",
+  "agent_manager.discovery.module_load_failed": "Warning: Could not load agent module {modname}: {error}",
+  "agent_manager.discovery.agent_load_failed": "Warning: Could not load agent {agent}: {error}",
+  "agent_manager.discovery.subpackage_load_failed": "Warning: Could not load agent sub-package {subpackage}: {error}",
+  "agent_manager.discovery.json_shadowed": "JSON agent '{agent_name}' skipped: builtin Python agent with the same name takes precedence.",
+  "agent_manager.discovery.json_discovery_failed": "Warning: Could not discover JSON agents: {error}",
+  "agent_manager.discovery.plugin_load_failed": "Warning: Could not load plugin agents: {error}",
+  "agent_manager.clone.source_not_found": "Agent '{agent_name}' not found for cloning.",
+  "agent_manager.clone.build_failed": "Failed to build clone for '{agent_name}': {error}",
+  "agent_manager.clone.target_exists": "Clone target '{clone_name}' already exists.",
+  "agent_manager.clone.success": "Cloned '{agent_name}' to '{clone_name}'.",
+  "agent_manager.clone.write_failed": "Failed to write clone file '{clone_path}': {error}",
+  "agent_manager.delete.not_clone": "Agent '{agent_name}' is not a clone.",
+  "agent_manager.delete.active_agent": "Cannot delete the active agent. Switch agents first.",
+  "agent_manager.delete.not_found": "Clone '{agent_name}' not found.",
+  "agent_manager.delete.not_json": "Clone '{agent_name}' is not a JSON agent.",
+  "agent_manager.delete.file_not_found": "Clone file for '{agent_name}' does not exist.",
+  "agent_manager.delete.non_user": "Refusing to delete non-user clone '{agent_name}'.",
+  "agent_manager.delete.success": "Deleted clone '{agent_name}'.",
+  "agent_manager.delete.failed": "Failed to delete clone '{agent_name}': {error}"
 }

code_puppy/i18n/locales/es.json

@@ -227,5 +227,24 @@
   "model_menu.browser.exited": "✓ Se salió del navegador de modelos",
   "model_menu.browser.unsupported_provider": "No se puede agregar un modelo desde {provider}: {reason}",
   "model_menu.browser.no_tool_call_warning": "⚠️  {model} NO admite la llamada a herramientas.\n   Este modelo no podrá editar archivos, ejecutar comandos ni usar ninguna herramienta.\n   Será muy limitado para tareas de programación.",
-  "model_menu.browser.add_cancelled": "Adición de modelo cancelada."
+  "model_menu.browser.add_cancelled": "Adición de modelo cancelada.",
+  "agent_manager.discovery.module_load_failed": "Advertencia: No se pudo cargar el módulo de agente {modname}: {error}",
+  "agent_manager.discovery.agent_load_failed": "Advertencia: No se pudo cargar el agente {agent}: {error}",
+  "agent_manager.discovery.subpackage_load_failed": "Advertencia: No se pudo cargar el subpaquete de agentes {subpackage}: {error}",
+  "agent_manager.discovery.json_shadowed": "Se omitió el agente JSON '{agent_name}': el agente Python incorporado con el mismo nombre tiene prioridad.",
+  "agent_manager.discovery.json_discovery_failed": "Advertencia: No se pudieron descubrir los agentes JSON: {error}",
+  "agent_manager.discovery.plugin_load_failed": "Advertencia: No se pudieron cargar los agentes de complementos: {error}",
+  "agent_manager.clone.source_not_found": "No se encontró el agente '{agent_name}' para clonarlo.",
+  "agent_manager.clone.build_failed": "No se pudo crear el clon de '{agent_name}': {error}",
+  "agent_manager.clone.target_exists": "El destino del clon '{clone_name}' ya existe.",
+  "agent_manager.clone.success": "Se clonó '{agent_name}' como '{clone_name}'.",
+  "agent_manager.clone.write_failed": "No se pudo escribir el archivo del clon '{clone_path}': {error}",
+  "agent_manager.delete.not_clone": "El agente '{agent_name}' no es un clon.",
+  "agent_manager.delete.active_agent": "No se puede eliminar el agente activo. Cambia de agente primero.",
+  "agent_manager.delete.not_found": "No se encontró el clon '{agent_name}'.",
+  "agent_manager.delete.not_json": "El clon '{agent_name}' no es un agente JSON.",
+  "agent_manager.delete.file_not_found": "El archivo del clon '{agent_name}' no existe.",
+  "agent_manager.delete.non_user": "Se rechazó eliminar el clon de usuario externo '{agent_name}'.",
+  "agent_manager.delete.success": "Se eliminó el clon '{agent_name}'.",
+  "agent_manager.delete.failed": "No se pudo eliminar el clon '{agent_name}': {error}"
 }

code_puppy/i18n/locales/fr-CA.json

@@ -227,5 +227,24 @@
   "model_menu.browser.exited": "✓ Navigateur de modèles fermé",
   "model_menu.browser.unsupported_provider": "Impossible d'ajouter un modèle depuis {provider} : {reason}",
   "model_menu.browser.no_tool_call_warning": "⚠️  {model} ne prend PAS en charge l'appel d'outils.\n   Ce modèle ne pourra pas modifier des fichiers, exécuter des commandes ou utiliser d'outils.\n   Il sera très limité pour les tâches de programmation.",
-  "model_menu.browser.add_cancelled": "Ajout de modèle annulé."
+  "model_menu.browser.add_cancelled": "Ajout de modèle annulé.",
+  "agent_manager.discovery.module_load_failed": "Avertissement : impossible de charger le module d’agent {modname} : {error}",
+  "agent_manager.discovery.agent_load_failed": "Avertissement : impossible de charger l’agent {agent} : {error}",
+  "agent_manager.discovery.subpackage_load_failed": "Avertissement : impossible de charger le sous-paquet d’agents {subpackage} : {error}",
+  "agent_manager.discovery.json_shadowed": "Agent JSON '{agent_name}' ignoré : l’agent Python intégré portant le même nom a priorité.",
+  "agent_manager.discovery.json_discovery_failed": "Avertissement : impossible de découvrir les agents JSON : {error}",
+  "agent_manager.discovery.plugin_load_failed": "Avertissement : impossible de charger les agents des modules d’extension : {error}",
+  "agent_manager.clone.source_not_found": "Agent '{agent_name}' introuvable pour le clonage.",
+  "agent_manager.clone.build_failed": "Impossible de créer le clone de '{agent_name}' : {error}",
+  "agent_manager.clone.target_exists": "La cible du clone '{clone_name}' existe déjà.",
+  "agent_manager.clone.success": "'{agent_name}' cloné vers '{clone_name}'.",
+  "agent_manager.clone.write_failed": "Impossible d’écrire le fichier du clone '{clone_path}' : {error}",
+  "agent_manager.delete.not_clone": "L’agent '{agent_name}' n’est pas un clone.",
+  "agent_manager.delete.active_agent": "Impossible de supprimer l’agent actif. Changez d’agent d’abord.",
+  "agent_manager.delete.not_found": "Clone '{agent_name}' introuvable.",
+  "agent_manager.delete.not_json": "Le clone '{agent_name}' n’est pas un agent JSON.",
+  "agent_manager.delete.file_not_found": "Le fichier du clone '{agent_name}' n’existe pas.",
+  "agent_manager.delete.non_user": "Refus de supprimer le clone non utilisateur '{agent_name}'.",
+  "agent_manager.delete.success": "Clone '{agent_name}' supprimé.",
+  "agent_manager.delete.failed": "Impossible de supprimer le clone '{agent_name}' : {error}"
 }

tests/i18n/test_agent_manager_i18n.py

@@ -0,0 +1,52 @@
+"""Coverage for the agent manager's user-facing message extraction."""
+
+import re
+
+import pytest
+
+from code_puppy.i18n import catalog, pseudo, translate
+
+_PLACEHOLDER = re.compile(r"\{(\w+)\}")
+_NAMESPACE = "agent_manager."
+
+
+@pytest.fixture(autouse=True)
+def _reset_locale():
+    translate.set_locale("en-US")
+    catalog.reset()
+    yield
+    translate.set_locale("en-US")
+    catalog.reset()
+
+
+def _keys(locale="en-US"):
+    return [key for key in catalog.load_catalog(locale) if key.startswith(_NAMESPACE)]
+
+
+def test_agent_manager_namespace_is_complete_in_all_catalogs():
+    expected = set(_keys())
+    assert len(expected) == 19
+    for locale in ("es", "fr-CA"):
+        assert set(_keys(locale)) == expected
+
+
+def test_agent_manager_messages_resolve_and_pseudolocalize():
+    translate.set_locale("en-US")
+    assert all(translate.t(key) != key for key in _keys())
+    translate.set_locale(pseudo.PSEUDO_LOCALE)
+    assert all(translate.t(key).startswith("⟦") for key in _keys())
+
+
+def test_catalog_translations_preserve_placeholders():
+    catalogs = {locale: catalog.load_catalog(locale) for locale in ("en-US", "es", "fr-CA")}
+    for key in _keys():
+        source = set(_PLACEHOLDER.findall(catalogs["en-US"][key]))
+        assert source == set(_PLACEHOLDER.findall(catalogs["es"][key]))
+        assert source == set(_PLACEHOLDER.findall(catalogs["fr-CA"][key]))
+
+
+def test_dynamic_values_are_interpolated():
+    translate.set_locale("es")
+    assert "agent-x" in translate.t("agent_manager.clone.success", agent_name="agent-x", clone_name="agent-y")
+    assert "agent-y" in translate.t("agent_manager.clone.success", agent_name="agent-x", clone_name="agent-y")
+    assert "boom" in translate.t("agent_manager.discovery.plugin_load_failed", error="boom")