Skip to content

Commit c372bc4

Browse files
authored
Remove symfony/polyfill-php86 from require-dev (#3521)
The polyfill was masking the absence of SortDirection on Laravel < 13.8: since it was installed in all CI runs (including laravel: 12.*), the class always existed and bugs in code paths that depend on its absence could not be detected. On Laravel >= 13.8, the polyfill is available as a transitive dependency so SortDirection-specific tests still run via the class_exists() guard.
1 parent 4afafeb commit c372bc4

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

composer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@
6363
"phpstan/phpstan": "^1.10|^2.1",
6464
"phpunit/phpunit": "^10.3|^11.5.3|^12.5.12",
6565
"rector/rector": "^1.2|^2.3",
66-
"spatie/laravel-query-builder": "^5.6|^6",
67-
"symfony/polyfill-php86": "^1.37"
66+
"spatie/laravel-query-builder": "^5.6|^6"
6867
},
6968
"conflict": {
7069
"illuminate/bus": "< 10.37.2"

0 commit comments

Comments
 (0)