Add tests for dirty detection with dates, enums, and scalar type changes

Author: GromNaN

src/Eloquent/DocumentModel.php

@@ -392,6 +392,15 @@ public function originalIsEquivalent($key)
             return false;
         }
 
+        if ($this->isDateAttribute($key)) {
+            $attribute = $attribute instanceof UTCDateTime ? $this->asDateTime($attribute) : $attribute;
+            $original  = $original instanceof UTCDateTime ? $this->asDateTime($original) : $original;
+
+            // Comparison on DateTimeInterface values
+            // phpcs:disable SlevomatCodingStandard.Operators.DisallowEqualOperators.DisallowedEqualOperator
+            return $attribute == $original;
+        }
+
         if (is_scalar($attribute) || is_scalar($original)) {
             return false;
         }

tests/ModelTest.php

@@ -1120,6 +1120,45 @@ public function testGetDirtyEmbeddedDocument(): void
         $this->assertTrue($user->isDirty('address'));
     }
 
+    public function testGetDirtyDatetimeCast(): void
+    {
+        $user = User::create(['name' => 'John Doe', 'birthday' => new DateTime('1989-08-19 12:00:00')]);
+        $user = User::find($user->id);
+        $this->assertFalse($user->isDirty());
+
+        // Same date via Carbon: not dirty
+        $user->birthday = Carbon::parse('1989-08-19 12:00:00');
+        $this->assertFalse($user->isDirty('birthday'));
+
+        // Same date via DateTime: not dirty
+        $user->birthday = new DateTime('1989-08-19 12:00:00');
+        $this->assertFalse($user->isDirty('birthday'));
+
+        // Different date: dirty
+        $user->birthday = new DateTime('1990-01-01 00:00:00');
+        $this->assertTrue($user->isDirty('birthday'));
+
+        // Null vs date: dirty
+        $user->save();
+        $user->birthday = null;
+        $this->assertTrue($user->isDirty('birthday'));
+    }
+
+    public function testGetDirtyEnumCast(): void
+    {
+        $user = User::create(['name' => 'John Doe', 'member_status' => MemberStatus::Member]);
+        $user = User::find($user->id);
+        $this->assertFalse($user->isDirty());
+
+        // Same enum value: not dirty
+        $user->member_status = MemberStatus::Member;
+        $this->assertFalse($user->isDirty('member_status'));
+
+        // Setting null: dirty
+        $user->member_status = null;
+        $this->assertTrue($user->isDirty('member_status'));
+    }
+
     public function testChunkById(): void
     {
         User::create(['name' => 'fork', 'tags' => ['sharp', 'pointy']]);