You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have accumulated 4 open PRs that each add a piece of global forecasting groundwork independently, plus the already-closed #211. I propose to consolidate them into a single curated PR. This is the sibling pattern to #649 (probabilistic metrics).
Why consolidate rather than merge piecemeal:
No global datastore exists on main, no spherical graph builder, no global model. Every PR is groundwork pointing at a target that doesn't exist yet.
Where spherical graph construction lives: in neural-lam or upstream in weather-model-graphs? Probably the latter, with neural-lam just consuming it.
Whether NWP-standard global metrics (cos-lat weighted RMSE/MAE, ACC, etc.) extend DEFINED_METRICS or live in a sibling registry.
Ownership: TBD. To be decided at the next dev meeting alongside #63.
Authors of the absorbed PRs: thanks for the work. Your changes will be cited as the source for the corresponding pieces of the consolidated PR. If you want to be involved in the design discussion above, please subscribe to this issue.
I have accumulated 4 open PRs that each add a piece of global forecasting groundwork independently, plus the already-closed #211. I propose to consolidate them into a single curated PR. This is the sibling pattern to #649 (probabilistic metrics).
Why consolidate rather than merge piecemeal:
get_area_weights()in a newgeometry.py. Sequential merges lock in the conflict.prob_model_global#63 ("Merge global forecasting capabilities fromprob_model_global") is broader-scope strategic; this issue is the focused implementation track.PRs being folded in (closing with credit):
GlobalDummyDatastorewith all-zero boundary mask for testinggeometry.py(spherical coords, cos-lat weights) +graph_builder.py(KNN graph on sphere)Plus the already-closed #211 (@nehamanoj1105) which made boundary forcing optional in the old
ARModel.API contract to design here before implementation:
geometry.py,metrics.py, or on the datastore? Currently [Feat] Implement area weights for grid-point averaging #258 and feat: add geometry utilities for global domains (spherical coords, area weights, KNN graph) #473 propose different homes.None, or anis_global: boolproperty?). Add GlobalDummyDatastore for global domain testing #444 picked one; pick the canonical one.neural-lamor upstream inweather-model-graphs? Probably the latter, withneural-lamjust consuming it.DEFINED_METRICSor live in a sibling registry.Ownership: TBD. To be decided at the next dev meeting alongside #63.
Authors of the absorbed PRs: thanks for the work. Your changes will be cited as the source for the corresponding pieces of the consolidated PR. If you want to be involved in the design discussion above, please subscribe to this issue.