Merge pull request #169 from mirumee/missing_content_type

Missing Content-Type

Author: mat-sop

CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## UNRELEASED
+
+- Fixed `AsyncBaseClient` and `BaseClient` to send `Content-Type` header with requests.
+
+
 ## 0.7.0 (2023-06-01)
 
 - Added support for subscriptions as async generators.

ariadne_codegen/client_generators/dependencies/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success:

ariadne_codegen/client_generators/dependencies/base_client.py

@@ -45,7 +45,9 @@ def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return self.http_client.post(url=self.url, content=content)
+        return self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> dict[str, Any]:
         if not response.is_success:

tests/client_generators/dependencies/test_async_base_client.py

@@ -185,6 +185,31 @@ async def test_execute_sends_payload_with_serialized_datetime_without_exception(
     assert content["variables"]["arg"] == arg_value.isoformat()
 
 
+@pytest.mark.asyncio
+async def test_execute_sends_request_with_correct_content_type(httpx_mock):
+    httpx_mock.add_response()
+    client = AsyncBaseClient(url="http://base_url")
+
+    await client.execute("query Abc { abc }", {})
+
+    request = httpx_mock.get_request()
+    assert request.headers["Content-Type"] == "application/json"
+
+
+@pytest.mark.asyncio
+async def test_execute_sends_request_with_extra_headers_and_correct_content_type(
+    httpx_mock,
+):
+    httpx_mock.add_response()
+    client = AsyncBaseClient(url="http://base_url", headers={"h_key": "h_value"})
+
+    await client.execute("query Abc { abc }", {})
+
+    request = httpx_mock.get_request()
+    assert request.headers["h_key"] == "h_value"
+    assert request.headers["Content-Type"] == "application/json"
+
+
 @pytest.mark.parametrize(
     "status_code, response_content",
     [

tests/client_generators/dependencies/test_base_client.py

@@ -172,6 +172,27 @@ def test_execute_sends_payload_with_serialized_datetime_without_exception(httpx_
     assert content["variables"]["arg"] == arg_value.isoformat()
 
 
+def test_execute_sends_request_with_correct_content_type(httpx_mock):
+    httpx_mock.add_response()
+    client = BaseClient(url="http://base_url")
+
+    client.execute("query Abc { abc }", {})
+
+    request = httpx_mock.get_request()
+    assert request.headers["Content-Type"] == "application/json"
+
+
+def test_execute_sends_request_with_extra_headers_and_correct_content_type(httpx_mock):
+    httpx_mock.add_response()
+    client = BaseClient(url="http://base_url", headers={"h_key": "h_value"})
+
+    client.execute("query Abc { abc }", {})
+
+    request = httpx_mock.get_request()
+    assert request.headers["h_key"] == "h_value"
+    assert request.headers["Content-Type"] == "application/json"
+
+
 @pytest.mark.parametrize(
     "status_code, response_content",
     [

tests/main/clients/custom_config_file/expected_client/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success:

tests/main/clients/custom_files_names/expected_client/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success:

tests/main/clients/custom_scalars/expected_client/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success:

tests/main/clients/example/expected_client/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success:

tests/main/clients/extended_models/expected_client/async_base_client.py

@@ -88,7 +88,9 @@ async def execute(
         if variables:
             payload["variables"] = self._convert_dict_to_json_serializable(variables)
         content = json.dumps(payload, default=pydantic_encoder)
-        return await self.http_client.post(url=self.url, content=content)
+        return await self.http_client.post(
+            url=self.url, content=content, headers={"Content-Type": "application/json"}
+        )
 
     def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         if not response.is_success: