Skip to content

Commit 55690f6

Browse files
authored
Simplify summary comments for SQL statement methods
1 parent e111f13 commit 55690f6

1 file changed

Lines changed: 3 additions & 25 deletions

File tree

src/Providers/RepoDb.SapHana/RepoDb.SapHana/StatementBuilders/SapHanaStatementBuilder.cs

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -285,15 +285,7 @@ public override string CreateExists(string tableName,
285285
#region CreateInsert
286286

287287
/// <summary>
288-
/// Creates a SQL Statement for insert operation. Unlike the SQL-Server-family pattern of appending
289-
/// a trailing <c>SELECT ... AS "Result"</c> to hand the generated/primary key back through the same
290-
/// round-trip, HANA's ADO.NET client rejects a command text containing more than one statement -
291-
/// so this is left as the plain <c>INSERT</c> that <see cref="BaseStatementBuilder"/> already
292-
/// produces. RepoDb.Core's insert pipeline already has a fallback for exactly this
293-
/// (<c>IDbSetting.IsMultiStatementExecutable == false</c>, set on <see cref="SapHanaDbSetting"/>):
294-
/// an identity value is fetched via a separate <see cref="DbHelpers.SapHanaDbHelper.GetScopeIdentity{T}"/>
295-
/// round-trip, and a non-identity key is simply read back off the entity the caller already
296-
/// supplied it on.
288+
/// Creates a SQL Statement for insert operation.
297289
/// </summary>
298290
public override string CreateInsert(string tableName,
299291
IEnumerable<Field> fields = null,
@@ -313,11 +305,7 @@ public override string CreateInsert(string tableName,
313305
#region CreateInsertAll
314306

315307
/// <summary>
316-
/// Creates a SQL Statement for insert-all operation. <see cref="SapHanaDbSetting"/> has
317-
/// <c>IsMultiStatementExecutable = false</c>, so RepoDb.Core always forces <paramref name="batchSize"/>
318-
/// down to 1 before calling this method (true multi-row batching into a single round-trip isn't
319-
/// supported - see the remark on <see cref="CreateInsert"/>). Guard defensively anyway, then reuse
320-
/// the single-row <see cref="CreateInsert"/> statement, which already produces parameters for index 0.
308+
/// Creates a SQL Statement for insert-all operation.
321309
/// </summary>
322310
public override string CreateInsertAll(string tableName,
323311
IEnumerable<Field> fields = null,
@@ -375,11 +363,6 @@ public override string CreateMaxAll(string tableName,
375363

376364
/// <summary>
377365
/// Creates a SQL Statement for merge operation, using HANA's native <c>UPSERT ... WITH PRIMARY KEY</c>.
378-
/// Unlike <see cref="CreateInsert"/>, RepoDb.Core's merge pipeline has no fallback for reading a key
379-
/// back via a separate round-trip, so this can't append a trailing <c>SELECT ... AS "Result"</c>
380-
/// either (HANA rejects multi-statement command text - see the remark on <see cref="CreateInsert"/>).
381-
/// This is not a functional loss in practice: <c>UPSERT ... WITH PRIMARY KEY</c> requires the
382-
/// primary key value up front to match against, so it's already known on the entity being merged.
383366
/// </summary>
384367
public override string CreateMerge(string tableName,
385368
IEnumerable<Field> fields,
@@ -426,12 +409,7 @@ public override string CreateMerge(string tableName,
426409
#region CreateMergeAll
427410

428411
/// <summary>
429-
/// Creates a SQL Statement for merge-all operation. <see cref="SapHanaDbSetting"/> has
430-
/// <c>IsMultiStatementExecutable = false</c>, so RepoDb.Core always forces <paramref name="batchSize"/>
431-
/// down to 1 before calling this method (true multi-row batching into a single round-trip isn't
432-
/// supported - see the remark on <see cref="CreateInsertAll"/>). Guard defensively anyway, then
433-
/// reuse the single-row <see cref="CreateMerge"/> statement, which already produces parameters for
434-
/// index 0.
412+
/// Creates a SQL Statement for merge-all operation.
435413
/// </summary>
436414
public override string CreateMergeAll(string tableName,
437415
IEnumerable<Field> fields,

0 commit comments

Comments
 (0)