BugFix: support nfs-server.service unit name on SLES 16

SLES 16 ships the upstream nfs-utils unit (nfs-server.service) and
no longer provides the legacy SUSE nfsserver.service alias. The
Suse branch of NFSServer hard-coded 'nfsserver', causing
'systemctl restart nfsserver' to exit 5 ('Unit nfsserver.service
not found') and storage-over-NFS performance tests to fail at the
configure step.

Probe both service names at runtime and use whichever exists, so
SLES 12/15 ('nfsserver') and SLES 16+ ('nfs-server') both work.

Author: LiliDeng

lisa/tools/nfs_server.py

@@ -19,6 +19,19 @@ def command(self) -> str:
     def can_install(self) -> bool:
         return True
 
+    def _get_suse_service_name(self) -> str:
+        # SLES 15 and older expose the NFS server as ``nfsserver.service``.
+        # SLES 16 has switched to the upstream ``nfs-server.service`` unit
+        # name and the legacy alias is no longer shipped. Probe which one
+        # actually exists so the tool keeps working on both.
+        service = self.node.tools[Service]
+        for name in ("nfs-server", "nfsserver"):
+            if service.check_service_exists(name):
+                return name
+        # Fall back to the upstream name; restart will surface a clear
+        # ``Unit nfs-server.service not found`` error if NFS is missing.
+        return "nfs-server"
+
     def create_shared_dir(self, client_ips: List[str], dir_name: str) -> None:
         # create directory to share
         self.node.execute(f"chmod -R a+rwX {dir_name}", sudo=True)
@@ -51,7 +64,7 @@ def create_shared_dir(self, client_ips: List[str], dir_name: str) -> None:
             )
         elif isinstance(self.node.os, Suse):
             self.node.tools[Service].restart_service(
-                "nfsserver",
+                self._get_suse_service_name(),
             )
         else:
             raise UnsupportedDistroException(self.node.os)
@@ -63,7 +76,7 @@ def is_running(self) -> bool:
         elif isinstance(self.node.os, Debian):
             return service.check_service_exists("nfs-kernel-server")
         elif isinstance(self.node.os, Suse):
-            return service.check_service_exists("nfsserver")
+            return service.check_service_exists(self._get_suse_service_name())
         else:
             raise UnsupportedDistroException(self.node.os)
 
@@ -74,7 +87,7 @@ def stop(self) -> None:
         elif isinstance(self.node.os, Debian):
             service.stop_service("nfs-kernel-server")
         elif isinstance(self.node.os, Suse):
-            service.stop_service("nfsserver")
+            service.stop_service(self._get_suse_service_name())
         else:
             raise UnsupportedDistroException(self.node.os)
 
@@ -96,6 +109,8 @@ def _check_exists(self) -> bool:
         elif isinstance(self.node.os, Debian):
             return self.node.tools[Service].check_service_exists("nfs-kernel-server")
         elif isinstance(self.node.os, Suse):
-            return self.node.tools[Service].check_service_exists("nfs-server")
+            return self.node.tools[Service].check_service_exists(
+                self._get_suse_service_name()
+            )
         else:
             raise UnsupportedDistroException(self.node.os)