CLI: Make update notifications opt-in and suppress when --format json (#17350)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: JamesNK

src/Aspire.Cli/Commands/AddCommand.cs

@@ -21,6 +21,8 @@ internal sealed class AddCommand : BaseCommand
 {
     internal override HelpGroup HelpGroup => HelpGroup.AppCommands;
 
+    protected override bool UpdateNotificationsEnabled => true;
+
     private readonly IProjectLocator _projectLocator;
     private readonly IntegrationPackageSearchService _integrationPackageSearchService;
     private readonly IAddCommandPrompter _prompter;

src/Aspire.Cli/Commands/AgentInitCommand.cs

@@ -85,8 +85,6 @@ public AgentInitCommand(
             ConsoleInteractionService.NoneChoice)
     };
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     /// <summary>
     /// Public entry point for executing the init command.
     /// This allows McpInitCommand to delegate to this implementation.

src/Aspire.Cli/Commands/AgentMcpCommand.cs

@@ -85,8 +85,6 @@ public AgentMcpCommand(
         Options.Add(s_apiKeyOption);
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     /// <summary>
     /// Public entry point for executing the MCP server command.
     /// This allows McpStartCommand to delegate to this implementation.

src/Aspire.Cli/Commands/ApiGetCommand.cs

@@ -54,8 +54,6 @@ public ApiGetCommand(
         Options.Add(s_formatOption);
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     protected override async Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         using var activity = Telemetry.StartDiagnosticActivity(Name);

src/Aspire.Cli/Commands/ApiListCommand.cs

@@ -55,8 +55,6 @@ public ApiListCommand(
         Options.Add(s_formatOption);
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     protected override async Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         using var activity = Telemetry.StartDiagnosticActivity(Name);

src/Aspire.Cli/Commands/ApiSearchCommand.cs

@@ -67,8 +67,6 @@ public ApiSearchCommand(
         Options.Add(s_limitOption);
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     protected override async Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         using var activity = Telemetry.StartDiagnosticActivity(Name);

src/Aspire.Cli/Commands/BaseCommand.cs

@@ -17,7 +17,7 @@ internal abstract class BaseCommand : Command
 {
     private static readonly int[] s_suppressErrorLogsMessageExitCodes = [CliExitCodes.Cancelled, CliExitCodes.MissingRequiredArgument];
 
-    protected virtual bool UpdateNotificationsEnabled { get; } = true;
+    protected virtual bool UpdateNotificationsEnabled { get; }
 
     /// <summary>
     /// Gets the help group for this command.
@@ -114,7 +114,7 @@ protected BaseCommand(string name, string description, IFeatures features, ICliU
                 }
             }
 
-            if (UpdateNotificationsEnabled && features.IsFeatureEnabled(KnownFeatures.UpdateNotificationsEnabled, true))
+            if (UpdateNotificationsEnabled && !IsJsonFormatRequested(parseResult) && features.IsFeatureEnabled(KnownFeatures.UpdateNotificationsEnabled, true))
             {
                 try
                 {

src/Aspire.Cli/Commands/CacheCommand.cs

@@ -30,8 +30,6 @@ public ClearCommand(IInteractionService interactionService, IFeatures features,
         {
         }
 
-        protected override bool UpdateNotificationsEnabled => false;
-
         protected override Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
         {
             try

src/Aspire.Cli/Commands/CertificatesCleanCommand.cs

@@ -25,8 +25,6 @@ public CertificatesCleanCommand(ICertificateToolRunner certificateToolRunner, II
         _certificateToolRunner = certificateToolRunner;
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     protected override Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         InteractionService.DisplayMessage(KnownEmojis.Information, CertificatesCommandStrings.CleanProgress);

src/Aspire.Cli/Commands/CertificatesTrustCommand.cs

@@ -25,8 +25,6 @@ public CertificatesTrustCommand(ICertificateService certificateService, IInterac
         _certificateService = certificateService;
     }
 
-    protected override bool UpdateNotificationsEnabled => false;
-
     protected override async Task<CommandResult> ExecuteAsync(ParseResult parseResult, CancellationToken cancellationToken)
     {
         InteractionService.DisplayMessage(KnownEmojis.Information, CertificatesCommandStrings.TrustProgress);