Skip to content

Commit 53d1e36

Browse files
radicalCopilot
andcommitted
fix(cli): restore "route" verb in three comments mechanically renamed to "source"
The install-route → install-source terminology rename swept three sites where "route" was used as a verb ("forward/channel through"), not as the install-route concept. That left two ungrammatical comments and one broken cross-reference. - InstallationDiscovery.cs: "Source through the shared helper" → "Funnel through the shared helper". The sentence is about funneling a value through a helper function, not about an install source. - PeerInstallProbeTests.cs: "Source internal probe diagnostics … into the xunit test output" → "Forward internal probe diagnostics …". The sentence is about forwarding LogDebug output, not about an install source. - TemporaryNuGetConfigTests.cs: comment referenced the now-renamed test `GetAspireHomeDirectory_OnMacOS_PrRouteWithFirmlinkedProcessPath`. Update to `PrSourceWithFirmlinkedProcessPath` so the cross-reference is greppable. Comment-only; no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent c23526a commit 53d1e36

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/Aspire.Cli/Acquisition/InstallationDiscovery.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ private InstallationInfo DescribeSelf(string? processPath, IReadOnlyList<Install
7979
// identifier the install scripts wrote, not the C# enum name. For
8080
// sidecars with an unrecognized source value we surface the raw
8181
// string so users see "(unknown: future-source)" rather than nothing.
82-
// Source through the shared helper so an empty RawSource collapses to
82+
// Funnel through the shared helper so an empty RawSource collapses to
8383
// null and the JSON shape of `--self` matches the full discovery walk.
8484
var source = sidecar is not null ? GetSourceFromSidecar(sidecar) : null;
8585

tests/Aspire.Cli.Tests/Acquisition/PeerInstallProbeTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace Aspire.Cli.Tests.Acquisition;
1717
/// </summary>
1818
public class PeerInstallProbeTests(ITestOutputHelper outputHelper) : IDisposable
1919
{
20-
// Source internal probe diagnostics (LogDebug for "JSON without an
20+
// Forward internal probe diagnostics (LogDebug for "JSON without an
2121
// installation row", "invalid JSON", etc.) into the xunit test output
2222
// so a failure log tells us why the probe took whichever code path it
2323
// took. Keep the factory alive for the lifetime of the test class so

tests/Aspire.Cli.Tests/Packaging/TemporaryNuGetConfigTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public async Task CreateAsync_PackageSourceAddKeyMatchesPackageSourceMappingKey(
141141
// will accept after its own internal canonicalization (e.g. on macOS the
142142
// upstream caller must strip /private/var → /var before constructing the
143143
// PackageMapping — see CliPathHelper.StripMacOSFirmlinkPrefix and the
144-
// GetAspireHomeDirectory_OnMacOS_PrRouteWithFirmlinkedProcessPath test).
144+
// GetAspireHomeDirectory_OnMacOS_PrSourceWithFirmlinkedProcessPath test).
145145
// This test only pins the writer's symmetry contract.
146146
var mappings = new PackageMapping[]
147147
{

0 commit comments

Comments
 (0)