fixed logic error where kubeConfig.KubeConfig was never unset

Signed-off-by: reaper8055 <11490705+reaper8055@users.noreply.github.com>

Author: reaper8055

utils/kubernetes/apply-helm-chart.go

@@ -479,48 +479,49 @@ func createHelmActionConfig(c *Client, cfg ApplyHelmChartConfig) (*action.Config
 			tempFiles = append(tempFiles, keyFileName)
 			kubeConfig.KeyFile = &keyFileName
 		}
-	}
+	} else {
 
-	const (
-		clusterName = "meshery-cluster"
-		authInfo    = "meshkit-helm-user"
-	)
+		const (
+			clusterName = "meshery-cluster"
+			authInfo    = "meshkit-helm-user"
+		)
 
-	helmKubeConfig := clientcmdapi.NewConfig()
+		helmKubeConfig := clientcmdapi.NewConfig()
 
-	helmKubeConfig.Clusters[clusterName] = &clientcmdapi.Cluster{
-		Server:                   c.RestConfig.Host,
-		TLSServerName:            c.RestConfig.ServerName,
-		InsecureSkipTLSVerify:    c.RestConfig.Insecure,
-		CertificateAuthority:     c.RestConfig.CAFile,
-		CertificateAuthorityData: c.RestConfig.CAData,
-	}
+		helmKubeConfig.Clusters[clusterName] = &clientcmdapi.Cluster{
+			Server:                   c.RestConfig.Host,
+			TLSServerName:            c.RestConfig.ServerName,
+			InsecureSkipTLSVerify:    c.RestConfig.Insecure,
+			CertificateAuthority:     c.RestConfig.CAFile,
+			CertificateAuthorityData: c.RestConfig.CAData,
+		}
 
-	helmKubeConfig.AuthInfos[clusterName] = &clientcmdapi.AuthInfo{
-		Exec:         c.RestConfig.ExecProvider,
-		AuthProvider: c.RestConfig.AuthProvider,
-	}
+		helmKubeConfig.AuthInfos[authInfo] = &clientcmdapi.AuthInfo{
+			Exec:         c.RestConfig.ExecProvider,
+			AuthProvider: c.RestConfig.AuthProvider,
+		}
 
-	helmKubeConfig.Contexts[clusterName] = &clientcmdapi.Context{
-		Cluster:  clusterName,
-		AuthInfo: authInfo,
-	}
+		helmKubeConfig.Contexts[clusterName] = &clientcmdapi.Context{
+			Cluster:  clusterName,
+			AuthInfo: authInfo,
+		}
 
-	// explicitly setting kube context may not be required
-	helmKubeConfig.CurrentContext = clusterName
+		// explicitly setting kube context may not be required
+		helmKubeConfig.CurrentContext = clusterName
 
-	configBytes, err := clientcmd.Write(*helmKubeConfig)
-	if err != nil {
-		return nil, nil, fmt.Errorf("failed to write kubeconfig %v", err)
-	}
+		configBytes, err := clientcmd.Write(*helmKubeConfig)
+		if err != nil {
+			return nil, nil, fmt.Errorf("failed to write kubeconfig %v", err)
+		}
 
-	configFile, err := setDataAndReturnFilename(configBytes)
-	if err != nil {
-		return nil, nil, fmt.Errorf("failed to get kubeconfig file %v", err)
-	}
-	tempFiles = append(tempFiles, configFile)
+		configFile, err := setDataAndReturnFilename(configBytes)
+		if err != nil {
+			return nil, nil, fmt.Errorf("failed to get kubeconfig file %v", err)
+		}
+		tempFiles = append(tempFiles, configFile)
 
-	kubeConfig.KubeConfig = &configFile
+		kubeConfig.KubeConfig = &configFile
+	}
 
 	actionConfig := new(action.Configuration)
 	if err := actionConfig.Init(kubeConfig, cfg.Namespace, string(cfg.HelmDriver), cfg.Logger); err != nil {