linter: fix readability-use-concise-preprocessor-directives issues

Signed-off-by: Martin Olivier <martin.olivier@live.fr>

Author: martin-olivier

example/lib.cpp

@@ -1,7 +1,7 @@
 #include <string>
 #include <vector>
 
-#if defined(_WIN32)
+#ifdef _WIN32
 #define LIB_EXPORT __declspec(dllexport)
 #else
 #define LIB_EXPORT

include/dylib.hpp

@@ -22,7 +22,7 @@
 #include <filesystem>
 #endif
 
-#if defined(_WIN32)
+#ifdef _WIN32
 #ifndef WIN32_LEAN_AND_MEAN
 #define WIN32_LEAN_AND_MEAN
 #define DYLIB_UNDEFINE_LEAN_AND_MEAN
@@ -42,7 +42,7 @@
 #endif
 #endif
 
-#if defined(_WIN32)
+#ifdef _WIN32
 #define DYLIB_WIN_MAC_OTHER(win_def, mac_def, other_def) win_def
 #define DYLIB_WIN_OTHER(win_def, other_def) win_def
 #elif defined(__APPLE__)
@@ -224,14 +224,14 @@ class library {
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-function-type"
 #endif
-#if defined __clang__
+#ifdef __clang__
 #if __has_warning("-Wcast-function-type-mismatch")
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-function-type-mismatch"
 #endif
 #endif
         return reinterpret_cast<T *>(get_symbol(symbol_name));
-#if defined __clang__
+#ifdef __clang__
 #if __has_warning("-Wcast-function-type-mismatch")
 #pragma clang diagnostic pop
 #endif
@@ -286,7 +286,7 @@ class library {
 
 protected:
     native_handle_type m_handle{nullptr};
-#if defined(__APPLE__)
+#ifdef __APPLE__
     int m_fd{-1};
 #endif
 };

src/dylib.cpp

@@ -7,7 +7,7 @@
  * This library is released under MIT license
  */
 
-#if !defined(_WIN32)
+#ifndef _WIN32
 #include <dlfcn.h>
 #include <unistd.h>
 #endif
@@ -44,31 +44,31 @@ std::vector<internal_symbol_info> get_symbols(native_handle_type handle, int fd)
 std::string demangle_symbol(const char *symbol);
 
 static native_handle_type open_lib(const char *path) noexcept {
-#if defined(_WIN32)
+#ifdef _WIN32
     return LoadLibraryA(path);
 #else
     return dlopen(path, RTLD_NOW | RTLD_LOCAL);
 #endif
 }
 
 static native_symbol_type locate_symbol(native_handle_type lib, const char *name) noexcept {
-#if defined(_WIN32)
+#ifdef _WIN32
     return GetProcAddress(lib, name);
 #else
     return dlsym(lib, name);
 #endif
 }
 
 static void close_lib(native_handle_type lib) noexcept {
-#if defined(_WIN32)
+#ifdef _WIN32
     FreeLibrary(lib);
 #else
     dlclose(lib);
 #endif
 }
 
 static std::string get_error_description() noexcept {
-#if defined(_WIN32)
+#ifdef _WIN32
     WORD lang = MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US);
     char description[512];
     DWORD error_code;
@@ -91,15 +91,15 @@ static std::string get_error_description() noexcept {
 
 library::library(library &&other) noexcept {
     std::swap(m_handle, other.m_handle);
-#if defined(__APPLE__)
+#ifdef __APPLE__
     std::swap(m_fd, other.m_fd);
 #endif
 }
 
 library &library::operator=(library &&other) noexcept {
     if (this != &other) {
         std::swap(m_handle, other.m_handle);
-#if defined(__APPLE__)
+#ifdef __APPLE__
         std::swap(m_fd, other.m_fd);
 #endif
     }
@@ -116,7 +116,7 @@ library::library(const char *lib_path, dylib::decorations decorations) {
 
     lib = lib_path;
 
-#if defined(_WIN32)
+#ifdef _WIN32
     while (lib.find('\\') != std::string::npos)
         lib.replace(lib.find('\\'), 1, "/");
 #endif
@@ -139,7 +139,7 @@ library::library(const char *lib_path, dylib::decorations decorations) {
     if (!m_handle)
         throw load_error("Could not load library '" + lib + "':\n" + get_error_description());
 
-#if defined(__APPLE__)
+#ifdef __APPLE__
     m_fd = open(lib.c_str(), O_RDONLY);
     if (m_fd < 0)
         throw load_error("Could not open file '" + lib + "':\n" + strerror(errno));
@@ -157,7 +157,7 @@ library::library(const std::filesystem::path &lib_path, decorations decorations)
 library::~library() {
     if (m_handle)
         close_lib(m_handle);
-#if defined(__APPLE__)
+#ifdef __APPLE__
     if (m_fd > -1)
         close(m_fd);
 #endif

src/symbols.cpp

@@ -58,7 +58,7 @@ static void add_symbol(std::vector<internal_symbol_info> &result, const char *sy
 }
 
 /************************   Windows   ************************/
-#if defined(_WIN32)
+#ifdef _WIN32
 
 #include <windows.h>
 #include <tchar.h>

tests/tests.cpp

@@ -16,7 +16,7 @@
 #include "dylib.hpp"
 #include "lib.hpp"
 
-#if !defined(_WIN32)
+#ifndef _WIN32
 #include <dlfcn.h>
 #endif
 
@@ -85,14 +85,14 @@ TEST(library, handle_management) {
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-function-type"
 #endif
-#if defined __clang__
+#ifdef __clang__
 #if __has_warning("-Wcast-function-type-mismatch")
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-function-type-mismatch"
 #endif
 #endif
     auto res = ((double (*)(double, double))(sym))(10, 10);
-#if defined __clang__
+#ifdef __clang__
 #if __has_warning("-Wcast-function-type-mismatch")
 #pragma clang diagnostic pop
 #endif