fix(page): error when updating pages with People properties (#402)

Author: mariosimao

CHANGELOG.md

@@ -6,8 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## Fixed
+- Error when updating pages with People properties.
+
 ## Build
-- Fix failing CI actions due to outdated codecov version.
+- Fix failing CI actions due to outdated dependencies.
 
 ## [v1.14.0] 2024-04-22
 

src/Pages/Properties/People.php

@@ -53,7 +53,7 @@ public function toArray(): array
 
         $array["people"] = array_map(
             function (User $user): array {
-                return $user->toArray();
+                return [ "id" => $user->id ];
             },
             $this->users,
         );

src/Users/User.php

@@ -30,6 +30,18 @@ private function __construct(
     ) {
     }
 
+    public static function create(string $id): self
+    {
+        return new self(
+            id: $id,
+            name: null,
+            avatarUrl: null,
+            type: null,
+            person: null,
+            bot: null,
+        );
+    }
+
     /** @psalm-param UserJson $array */
     public static function fromArray(array $array): self
     {

tests/Integration/DatabasesTest.php

@@ -9,6 +9,7 @@
 use Notion\Databases\Database;
 use Notion\Databases\DatabaseParent;
 use Notion\Databases\Properties\Date;
+use Notion\Databases\Properties\People;
 use Notion\Databases\Properties\RichTextProperty;
 use Notion\Databases\Properties\Select;
 use Notion\Databases\Properties\SelectOption;
@@ -21,8 +22,10 @@
 use Notion\Pages\Page;
 use Notion\Pages\PageParent;
 use Notion\Pages\Properties\Date as DateProp;
+use Notion\Pages\Properties\People as PeopleProp;
 use Notion\Pages\Properties\Select as SelectProp;
 use Notion\Search\Query as SearchQuery;
+use Notion\Users\User;
 use PHPUnit\Framework\TestCase;
 
 class DatabasesTest extends TestCase
@@ -204,13 +207,46 @@ public function test_query_inexistent_database(): void
         $client->databases()->query($database, $query);
     }
 
+    public function test_rename_database_with_people_property(): void
+    {
+        $client = Helper::client();
+
+        $database = self::moviesDatabase();
+        $database = $database->changeTitle("New movies database");
+        $database = $client->databases()->update($database);
+
+        $client->databases()->delete($database);
+
+        $this->assertSame("New movies database", $database->title[0]->plainText);
+    }
+
+    public function test_rename_database_page_with_people_property(): void
+    {
+        $client = Helper::client();
+
+        $database = self::moviesDatabase();
+
+        $users = Helper::client()->users()->findAll();
+        $userId = $users[0]->id;
+
+        $newPage = self::moviePage($database->id, "Sample movie", "2023-01-01", "Action", $userId);
+        $newPage = $client->pages()->create($newPage);
+
+        $newPage = $newPage->changeTitle("Updated sample movie");
+        $client->pages()->update($newPage);
+
+        $client->databases()->delete($database);
+
+        $this->assertSame("Updated sample movie", $newPage->title()?->toString());
+    }
+
     private static function moviesDatabase(): Database
     {
         $databaseParent = DatabaseParent::page(Helper::testPageId());
 
         $categories = [
             SelectOption::fromName("Action")->changeColor(Color::Orange),
-            SelectOption::fromname("Comedy")->changeColor(Color::Yellow),
+            SelectOption::fromName("Comedy")->changeColor(Color::Yellow),
             SelectOption::fromName("Drama")->changeColor(Color::Red),
         ];
 
@@ -220,16 +256,20 @@ private static function moviesDatabase(): Database
                 "Movies" => Title::create("Movie"),
                 "Release date" => Date::create("Release date"),
                 "Category" => Select::create("Category", $categories),
+                "People" => People::create("People"),
             ]);
 
         $database = Helper::client()->databases()->create($database);
 
+        $users = Helper::client()->users()->findAll();
+        $userId = $users[0]->id;
+
         $pages = [
-            self::moviePage($database->id, "A Clockwork Orange", "1972-12-19", "Drama"),
-            self::moviePage($database->id, "Dead Poets Society", "1989-06-02", "Drama"),
-            self::moviePage($database->id, "Batman", "1989-10-26", "Action"),
-            self::moviePage($database->id, "The Mask", "1994-12-23", "Comedy"),
-            self::moviePage($database->id, "American Beauty", "1999-09-08", "Drama"),
+            self::moviePage($database->id, "A Clockwork Orange", "1972-12-19", "Drama", $userId),
+            self::moviePage($database->id, "Dead Poets Society", "1989-06-02", "Drama", $userId),
+            self::moviePage($database->id, "Batman", "1989-10-26", "Action", $userId),
+            self::moviePage($database->id, "The Mask", "1994-12-23", "Comedy", $userId),
+            self::moviePage($database->id, "American Beauty", "1999-09-08", "Drama", $userId),
         ];
 
         $client = Helper::client();
@@ -244,13 +284,15 @@ private static function moviePage(
         string $databaseId,
         string $title,
         string $releaseDate,
-        string $category
+        string $category,
+        string $userId
     ): Page {
         $date = new DateTimeImmutable($releaseDate);
         return Page::create(PageParent::database($databaseId))
             ->changeTitle($title)
             ->addProperty("Release date", DateProp::create($date))
-            ->addProperty("Category", SelectProp::fromname($category));
+            ->addProperty("Category", SelectProp::fromName($category))
+            ->addProperty("People", PeopleProp::create(User::create($userId)));
     }
 
     private static function bigDatabase(): Database

tests/Unit/Pages/Properties/PeopleTest.php

@@ -57,8 +57,8 @@ public function test_array_conversion(): void
             "id" => "abc",
             "type" => "people",
             "people" => [
-                $this->user1()->toArray(),
-                $this->user2()->toArray(),
+                [ "id" => $this->user1()->id ],
+                [ "id" => $this->user2()->id ],
             ],
         ];