Reapply "Reapply "Improved TextToy image formatting""

This reverts commit 1ac3698.

Author: marchellcx

LabExtended/API/Images/Conversion/ToyStringImageConvertor.cs

@@ -1,6 +1,11 @@
-using NorthwoodLib.Pools;
+using LabExtended.API.Toys;
+
+using NorthwoodLib.Pools;
+
 using LabExtended.Utilities;
+
 using UnityEngine;
+
 using Color = System.Drawing.Color;
 
 namespace LabExtended.API.Images.Conversion;
@@ -36,7 +41,6 @@ public class ToyStringImageData
     /// </summary>
     public static char Character { get; set; } = '█';
 
-    // TODO: Optimize the string conversion - aka lets not have a different collection item for each row.
     /// <summary>
     /// Assigns text toy data to each image frame.
     /// </summary>
@@ -47,26 +51,26 @@ public static void ConvertImage(ImageFile file)
         if (file is null)
             throw new ArgumentNullException(nameof(file));
 
+        file.toyDisplaySize = new(file.Height, file.Width);
+        
         var builder = StringBuilderPool.Shared.Rent();
 
         Color? last = null;
 
-        file.toyDisplaySize = new(file.Height, file.Width);
-        
         for (var index = 0; index < file.Frames.Count; index++)
         {
             var frame = file.Frames[index];
 
+            builder.Clear();
+            
+            builder.Append("<size=");
+            builder.Append(file.toyStringImageData.CharacterSize);
+            builder.Append("%><line-height=");
+            builder.Append(file.toyStringImageData.CharacterHeight);
+            builder.Append("%>");
+
             for (var x = 0; x < frame.Pixels.Count; x++)
             {
-                builder.Clear();
-                
-                builder.Append("<size=");
-                builder.Append(file.toyStringImageData.CharacterSize);
-                builder.Append("%><line-height=");
-                builder.Append(file.toyStringImageData.CharacterHeight);
-                builder.Append("%>");
-
                 var pixels = frame.Pixels[x];
 
                 for (var y = 0; y < pixels.Count; y++)
@@ -78,29 +82,19 @@ public static void ConvertImage(ImageFile file)
                         builder.Append("<color=");
                         builder.Append(pixel.Color.ToShortHex());
                         builder.Append(">");
-                        
+
                         last = pixel.Color;
                     }
 
                     builder.Append(Character);
                 }
 
-                builder.Append("</color>");
-
-                frame.toyFrameData.Add(builder.ToString());
-            }
-            
-            builder.Clear();
-
-            for (var i = 0; i < file.Height; i++)
-            {
-                builder.Append("{");
-                builder.Append(i);
-                builder.Append("}");
-                builder.Append("\\n");
+                builder.AppendLine();
             }
 
-            frame.toyFrameFormat = builder.ToString();
+            builder.Append("</color>");
+            
+            TextToy.SplitStringNonAlloc(builder.ToString(), frame.toyFrameData, out frame.toyFrameFormat);
         }
 
         StringBuilderPool.Shared.Return(builder);

LabExtended/API/MirrorMethods.cs

@@ -22,6 +22,11 @@ namespace LabExtended.API;
 /// </summary>
 public static class MirrorMethods
 {
+    /// <summary>
+    /// Gets the maximum length of a string.
+    /// </summary>
+    public const int MaxStringLength = 65534;
+    
     /// <summary>
     /// Gets full names of all RPCs.
     /// <remarks>Keys are formatted as the declaring type of the property and then the name of the property