Commit 5f1df22
committed
fix(charts): emit leading document separators in monitoring partials
The routerlib service-monitor and rbac partials open their conditional
bodies without a leading '---'. Include sites chain partials on
adjacent lines and rely on each partial to separate itself, so with
router.monitoring.prometheus.enabled=true the rendered ServiceMonitor
continues the preceding EPP Service document, forming one YAML document
with duplicate root keys. Helm parses that document last-key-wins as a
ServiceMonitor and the Service drops out of the release inventory: an
upgrade that enables monitoring deletes the live Service, a fresh
install with monitoring enabled never creates it, and Helm reports no
error. Observed on GKE with Helm v4.2.0.
The rbac partial fails the same way when the service-monitor partial
renders empty (prometheus enabled with a provider other than
prometheusoperator): its ClusterRole fuses onto the Service.
Add a leading '---' inside each conditional, matching
_leader-election-rbac.yaml.
Signed-off-by: Luke Van Drie <lukevandrie@google.com>1 parent 800ec0e commit 5f1df22
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
0 commit comments