Skip to content

datalayer/metrics/verl: Searching for metrics can be done better #28

Description

@aniketmohanty82

Currently, vllm.py and sglang.py both use regex to search for different metric values. This is both unsafe and unreadable. We should use the prometheus_client in python instead. It contains a parser specifically designed to parse the Prometheus text exposition format into structured Python objects. Instead of using raw regex, we can use prometheus_client.parser.text_string_to_metric_families. Haven't implemented this yet as I cannot test it right now but will when I can.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions