Skip to content

Fix the 101 ruff lint errors in pkg/client/python surfaced by ruff 0.16.0 #116

Description

@aishukamal

ruff 0.16.0 (released 2026-07-23) reports 101 errors in pkg/client/python/ that 0.15.x did not, failing python-lint-and-test for every PR (first seen on #112, which touches no Python).

Why these files are exposed: pkg/client/python/pyproject.toml contains only pb2 excludes and no [tool.ruff.lint] section, so those files run on ruff's default rule set — which shifts with new ruff minor versions. The curated select list in the root pyproject.toml does not apply to them.

CI is being unblocked short-term by pinning ruff in the workflow (see linked PR). This issue tracks the real fix:

  • Fix the 101 findings (mostly FA100 from __future__ import annotations and friends; 29 are auto-fixable with ruff check --fix)
  • Give pkg/client/python an explicit [tool.ruff.lint] config (or inherit the root ruleset) so its lint surface is deterministic
  • Then bump the pinned ruff version in .github/workflows/ci-pr-checks.yaml

Example failing run: https://github.com/llm-d-incubation/llm-d-rl-time-slicing/actions/runs/30046767418/job/89339653339

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions