Commit f4db72b
committed
tests: consolidate integration tests on a shared framework and the rlts scenarios
Extract the generic pieces of the snapshot-agent integration harness into
tests/integration/harness — in-cluster client setup, node selection
(TEST_NODE / free-GPU pick), pod lifecycle, exec (with stdin) / HTTP /
VRAM helpers, and attach-by-label for chart-deployed pods. The
snapshot-agent suite keeps its specifics (agent deployment, engine specs,
agentctl call path) and composes the shared Cluster.
Move the orchestrator E2E scenario drivers (RunSingleRLJobScenario,
RunQueuedRLJobsScenario, FakeRLJob, PodFactory, Logger) from
test/e2e/acceleratororchestrator to pkg/accelerator-orchestrator/scenarios
so one implementation serves the rlts CLI, the in-process go tests (which
stay in test/e2e with their fakes), and the integration suite.
The suite gains the orchestrator phase: run.sh installs the official
accelerator-orchestrator chart, labels TEST_NODE with the
samplers/trainers groups, and TestOrchestrator runs the shared scenarios
against it with a new pause pod template (no GPU work). The chart gains a
snapshotAgentPort value; the phase points it at an unused port because a
real agent correctly reports jobs without GPU activity as idle-not-loaded
(stalling lock handoffs) — the agentless mode is what
'rlts test orchestrator' targets on orchestrator-only deployments, and
agent-driven C/R scenarios need real GPU workloads (future work).
run.sh is the single integration entrypoint: --phase all (default) =
standalone + k8s + orchestrator, and --build now also covers the
orchestrator image.
Signed-off-by: Aishu Kamal <aishuk@google.com>1 parent 2ea7fb7 commit f4db72b
13 files changed
Lines changed: 580 additions & 298 deletions
File tree
- cmd/rlts/cmd
- deploy/acceleratororchestrator
- templates
- pkg/accelerator-orchestrator/scenarios
- tests/integration
- harness
- snapshot-agent
- test/e2e/acceleratororchestrator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| |||
220 | 220 | | |
221 | 221 | | |
222 | 222 | | |
223 | | - | |
| 223 | + | |
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
2 | 16 | | |
3 | 17 | | |
4 | 18 | | |
| |||
Lines changed: 15 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
65 | 79 | | |
66 | 80 | | |
67 | 81 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
155 | | - | |
| 156 | + | |
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
| |||
283 | 284 | | |
284 | 285 | | |
285 | 286 | | |
286 | | - | |
| 287 | + | |
287 | 288 | | |
288 | 289 | | |
289 | 290 | | |
| |||
0 commit comments