fix go ci (#1473)

* fix go ci

* lint ignore syntax

* better linter

* tidy

Author: paulwe

.github/workflows/buildtest.yaml

@@ -40,16 +40,15 @@ jobs:
           go-version-file: "go.mod"
 
       - name: Set up gotestfmt
-        run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@v2.4.1
+        run: go install github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt@9eae5abc81d6d08f73268741ef4a8b97f29b60d8 # v2.4.1
 
       - name: Download Go modules
         run: go mod download
 
-      - name: Static Check
-        uses: amarpal/staticcheck-action@ab84170fc40f72c7045b5d669e149e06c2b96439
+      - name: Lint
+        uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
-          checks: '["all", "-ST1000", "-ST1003", "-ST1020", "-ST1021", "-ST1022", "-SA1019"]'
-          install-go: false
+          version: v2.11.4
 
       - name: Test
         run: |

.golangci.yml

@@ -0,0 +1,16 @@
+version: "2"
+linters:
+  default: none
+  enable:
+    - staticcheck
+  settings:
+    staticcheck:
+      checks:
+        - "all"
+        - "-ST1000"
+        - "-ST1003"
+        - "-ST1020"
+        - "-ST1021"
+        - "-ST1022"
+        - "-SA1019"
+        - "-QF1008"

go.mod

@@ -1,6 +1,6 @@
 module github.com/livekit/protocol
 
-go 1.24.0
+go 1.25.0
 
 require (
 	buf.build/go/protoyaml v0.6.0

ingress/validation.go

@@ -120,7 +120,7 @@ func ValidateEnableTranscoding(info *livekit.IngressInfo) error {
 		}
 	} else {
 		enableTranscoding = true
-		if info.EnableTranscoding != nil && *info.EnableTranscoding == false {
+		if info.EnableTranscoding != nil && !*info.EnableTranscoding {
 			return NewInvalidTranscodingBypassError("bypassing transcoding impossible with selected input type")
 		}
 	}

livekit/sip.go

@@ -325,7 +325,7 @@ func validateAttributesToHeaders(attributesToHeaders map[string]string) error {
 
 // validateHeaderToAttributes Makes sure the keys of the given map correspond to valid SIP header names
 func validateHeaderToAttributes(headerToAttributes map[string]string) error {
-	for headerName, _ := range headerToAttributes {
+	for headerName := range headerToAttributes {
 		if err := ValidateHeaderName(headerName, false); err != nil {
 			return fmt.Errorf("invalid header name: %w", err)
 		}

logger/zaputil/zaputil_test.go

@@ -51,8 +51,8 @@ func (c *testCore) With(fields []zapcore.Field) zapcore.Core {
 	}
 }
 
-func (s *testCore) Write(entry zapcore.Entry, fields []zapcore.Field) error {
-	s.init()
-	s.writeCount.Inc()
+func (c *testCore) Write(entry zapcore.Entry, fields []zapcore.Field) error {
+	c.init()
+	c.writeCount.Inc()
 	return nil
 }

sip/sip.go

@@ -272,7 +272,7 @@ func GetPinAndRoom(info *livekit.SIPDispatchRuleInfo) (room, pin string, err err
 	// TODO: Could probably add methods on SIPDispatchRuleInfo struct instead.
 	switch rule := info.GetRule().GetRule().(type) {
 	default:
-		return "", "", fmt.Errorf("Unsupported SIP Dispatch Rule: %T", rule)
+		return "", "", fmt.Errorf("Unsupported SIP Dispatch Rule: %T", rule) //nolint:staticcheck // part of public API
 	case *livekit.SIPDispatchRule_DispatchRuleDirect:
 		pin = rule.DispatchRuleDirect.GetPin()
 		room = rule.DispatchRuleDirect.GetRoomName()
@@ -874,7 +874,7 @@ func EvaluateDispatchRule(projectID string, trunk *livekit.SIPInboundTrunkInfo,
 			// This should never happen in practice, because matchSIPDispatchRule should remove rules with the wrong pin.
 			return nil, twirp.NewError(twirp.PermissionDenied, "Incorrect PIN for SIP room")
 		}
-	} else {
+	} else { //nolint:staticcheck // empty branch provides context for comment
 		// Pin was sent, but room doesn't require one. Assume user accidentally pressed phone button.
 	}
 	switch rule := rule.GetRule().GetRule().(type) {
@@ -898,19 +898,19 @@ func EvaluateDispatchRule(projectID string, trunk *livekit.SIPInboundTrunkInfo,
 			room += "_" + guid.New("")
 		}
 	}
-	attrs[livekit.AttrSIPDispatchRuleID] = rule.SipDispatchRuleId
+	attrs[livekit.AttrSIPDispatchRuleID] = rule.GetSipDispatchRuleId()
 	resp := &rpc.EvaluateSIPDispatchRulesResponse{
 		ProjectId:             projectID,
 		SipTrunkId:            trunkID,
-		SipDispatchRuleId:     rule.SipDispatchRuleId,
+		SipDispatchRuleId:     rule.GetSipDispatchRuleId(),
 		Result:                rpc.SIPDispatchResult_ACCEPT,
 		RoomName:              room,
 		ParticipantIdentity:   fromID,
 		ParticipantName:       fromName,
-		ParticipantMetadata:   rule.Metadata,
+		ParticipantMetadata:   rule.GetMetadata(),
 		ParticipantAttributes: attrs,
-		RoomPreset:            rule.RoomPreset,
-		RoomConfig:            rule.RoomConfig,
+		RoomPreset:            rule.GetRoomPreset(),
+		RoomConfig:            rule.GetRoomConfig(),
 		MediaEncryption:       enc,
 	}
 	krispEnabled := false

utils/deepcopy_test.go

@@ -28,7 +28,7 @@ type copyTestType struct {
 	Vmap           map[int]int
 	Vpointer       *copyTestType
 	VunsafePointer unsafe.Pointer
-	vunexported    bool
+	vunexported    bool //nolint:unused // tests deep copy of unexported fields
 }
 
 func TestDeepCopy(t *testing.T) {

utils/events/emitter.go

@@ -301,7 +301,7 @@ type blockingObserver[V any] struct {
 	ch   chan V
 }
 
-func (o *blockingObserver[V]) emit(v V) {
+func (o *blockingObserver[V]) emit(v V) { //nolint:unused // implements Observer interface
 	select {
 	case o.ch <- v:
 	case <-o.done:
@@ -318,7 +318,7 @@ func (o *blockingObserver[V]) Events() <-chan V {
 
 type nonblockingCallback[V any] func(V)
 
-func (o nonblockingCallback[V]) emit(v V) {
+func (o nonblockingCallback[V]) emit(v V) { //nolint:unused // implements Observer interface
 	go o(v)
 }
 
@@ -328,7 +328,7 @@ func (o nonblockingCallback[V]) Events() <-chan V { return nil }
 
 type blockingCallback[V any] func(V)
 
-func (o blockingCallback[V]) emit(v V) {
+func (o blockingCallback[V]) emit(v V) { //nolint:unused // implements Observer interface
 	o(v)
 }
 

utils/list/list.go

@@ -5,7 +5,7 @@ type Hook[T any] struct {
 	prev *T
 }
 
-func (h *Hook[T]) getListHook() *Hook[T] {
+func (h *Hook[T]) getListHook() *Hook[T] { //nolint:unused // implements hookAccessor interface
 	return h
 }