Skip to content

Commit cba9f66

Browse files
fix(review): wire Deployment annotations and fix systemPrompt JSON
Two fixes from PR #1285 (ArgoCD) review feedback: - deployment.yaml: add {{- with .Values.annotations }} block to Deployment metadata so reloader.stakater.com/auto: "true" (already set in global ArgoCD values) is actually applied. Without this the Stakater Reloader never sees the annotation and ConfigMap changes don't trigger a rolling restart. - values.yaml: replace invalid JSON tokens (..., // comments) in the weeklyBriefPrompts.systemPrompt schema example with valid placeholder values and move cardinality rules to plain-text sentences. A model that copies the example now produces parseable JSON. Signed-off-by: Andres Tobon <atobon@linuxfoundation.org> Signed-off-by: Andres Tobon <andrest2455@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 14a1bbd commit cba9f66

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

charts/lfx-v2-committee-service/templates/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ metadata:
88
namespace: {{ .Release.Namespace }}
99
labels:
1010
app.kubernetes.io/name: {{ .Chart.Name }}
11+
{{- with .Values.annotations }}
12+
annotations:
13+
{{- toYaml . | nindent 4 }}
14+
{{- end }}
1115
spec:
1216
replicas: {{ .Values.replicaCount }}
1317
selector:

charts/lfx-v2-committee-service/values.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -634,10 +634,13 @@ weeklyBriefPrompts:
634634
You are a writing assistant that produces concise weekly briefs for open-source committee working groups.
635635
Respond ONLY with a JSON object matching this schema:
636636
{
637-
"claim_ids": ["string", ...], // at least one claim id, taken from the supplied claims
638-
"source_refs": [{"type": "string", "id": "string"}, ...], // at least one
639-
"brief_text": "string" // two paragraphs separated by a blank line
637+
"claim_ids": ["claim-id-1"],
638+
"source_refs": [{"type": "source-type", "id": "source-id"}],
639+
"brief_text": "Paragraph one.\n\nParagraph two."
640640
}
641+
The claim_ids array must contain at least one claim id from the supplied claims.
642+
The source_refs array must contain at least one source reference.
643+
The brief_text must be exactly two paragraphs separated by a blank line.
641644
Do not include any prose outside the JSON object.
642645
643646
# userPromptTemplate is a Go text/template rendered with the WeeklyBriefInput

0 commit comments

Comments
 (0)