fix(review): address PR #121 review feedback

Address review comments from copilot-pull-request-reviewer:

- client.go: add messaging.operation.type="publish" to producer span
  attributes in publishWithSpan to match documented semconv schema
- client.go: add messaging.operation.type="process" to consumer span
  attributes in SubscribeWithTransportMessenger to match documented
  semconv schema
- client.go: remove unconditional span.SetStatus(codes.Ok) after handler
  returns; leave status unset on success per OTel spec, only set Error
  on panic/failures
- tracing_test.go: rename subtest to "Set/Get round-trip preserves
  values" — the body only exercises carrier.Set/Get, not a propagator

Resolves 4 review threads.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Issue: LFXV2-1743
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>

Author: bramwelt

internal/infrastructure/nats/client.go

@@ -119,6 +119,7 @@ func (c *NATSClient) publishWithSpan(ctx context.Context, subject string, data [
 		trace.WithAttributes(
 			attribute.String("messaging.system", "nats"),
 			attribute.String("messaging.destination.name", subject),
+			attribute.String("messaging.operation.type", "publish"),
 			attribute.Int("messaging.message.body.size", len(data)),
 		),
 	)
@@ -177,6 +178,7 @@ func (c *NATSClient) SubscribeWithTransportMessenger(ctx context.Context, subjec
 			trace.WithAttributes(
 				attribute.String("messaging.system", "nats"),
 				attribute.String("messaging.destination.name", subject),
+				attribute.String("messaging.operation.type", "process"),
 				attribute.Int("messaging.message.body.size", len(msg.Data)),
 			),
 		)
@@ -197,7 +199,6 @@ func (c *NATSClient) SubscribeWithTransportMessenger(ctx context.Context, subjec
 		}()
 
 		handler(msgCtx, transportMsg)
-		span.SetStatus(codes.Ok, "")
 	})
 }
 

internal/infrastructure/nats/tracing_test.go

@@ -88,7 +88,7 @@ func TestNatsHeaderCarrier_TextMapCarrier(t *testing.T) {
 		var _ propagation.TextMapCarrier = natsHeaderCarrier{}
 	})
 
-	t.Run("inject and extract round-trip via propagator", func(t *testing.T) {
+	t.Run("Set/Get round-trip preserves values", func(t *testing.T) {
 		header := make(natsgo.Header)
 		carrier := natsHeaderCarrier(header)